Skip to content

core: add Option::get_or_try_insert_with #143650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

core: add Option::get_or_try_insert_with #143650

wants to merge 1 commit into from
+44 −1

Conversation

lolbinarycat
Copy link
Contributor

Implementation for #143648

@rustbot
Copy link
Collaborator

rustbot commented Jul 8, 2025

r? @thomcc

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 8, 2025
@lolbinarycat lolbinarycat mentioned this pull request Jul 8, 2025
Open
4 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lolbinarycat lolbinarycat force-pushed the core-option_get_or_try_insert_with-143648 branch from f031640 to d09af04 Compare July 8, 2025 20:19
@bors
Copy link
Collaborator

bors commented Jul 18, 2025

☔ The latest upstream changes (presumably #144109) made this pull request unmergeable. Please resolve the merge conflicts.

@lolbinarycat lolbinarycat force-pushed the core-option_get_or_try_insert_with-143648 branch from d09af04 to 9e8f17f Compare July 19, 2025 17:08
@a1phyr
Copy link
Contributor

a1phyr commented Jul 21, 2025

About using the Try trait, we should probably try to be consistent with OnceLock::get_or_try_init. See discussion at #107122.

@lolbinarycat
Copy link
Contributor Author

@a1phyr i initially proposed this as just using Result, it was a t-libs decision to make it use Try.

see rust-lang/libs-team#577 (comment)

@lolbinarycat lolbinarycat force-pushed the core-option_get_or_try_insert_with-143648 branch from 9e8f17f to b8955c5 Compare August 5, 2025 17:40
@lolbinarycat
Copy link
Contributor Author

reviewer is inactive, rerolling

r? t-libs

@rustbot rustbot assigned the8472 and unassigned thomcc Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@the8472 the8472

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lolbinarycat @rustbot @rust-log-analyzer @bors @a1phyr @thomcc @the8472