Skip to content

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Jul 7, 2025

I messed this up in #142978. It is only an issue if someone enables the event manually, which almost no-one does, so it could take a while before we found it :D Luckily I noticed it while re-reading the PR.

r? @oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 7, 2025
@oli-obk
Copy link
Contributor

oli-obk commented Jul 7, 2025

oh lmao, copy pasta strikes again

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 7, 2025

📌 Commit 37115f1 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2025
bors added a commit that referenced this pull request Jul 8, 2025
Rollup of 7 pull requests

Successful merges:

 - #142098 (Implement `int_format_into` feature)
 - #143567 (Point to correct argument in Func Call when Self type fails trait bound)
 - #143570 (consider nested cases for duplicate RPITIT)
 - #143571 (remove `has_nested` from builtin candidates)
 - #143586 (Fix wrong cache event query key)
 - #143589 (const-block-as-pattern: do not refer to no-longer-existing nightly feature)
 - #143608 (Fix in std::String docs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1a45ab1 into rust-lang:master Jul 8, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 8, 2025
rust-timer added a commit that referenced this pull request Jul 8, 2025
Rollup merge of #143586 - Kobzol:self-profile-fix, r=oli-obk

Fix wrong cache event query key

I messed this up in #142978. It is only an issue if someone enables the event manually, which almost no-one does, so it could take a while before we found it :D Luckily I noticed it while re-reading the PR.

r? `@oli-obk`
@Kobzol Kobzol deleted the self-profile-fix branch July 8, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants