Skip to content

Use tracing-forest instead of tracing-tree for bootstrap tracing #143180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

Use tracing-forest instead of tracing-tree for bootstrap tracing #143180

merged 1 commit into from
Jul 1, 2025

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Jun 29, 2025 •
edited
Loading

I find the tracing-forest output easier to comprehend.

Note that this is not a strict improvement -- tracing-forest output contains some emojis and redundant log levels, but customizing it seems to be... non-trivial. Despite this, I still find tracing-forest easier to follow than tracing-tree, even when I tried to tune tracing-tree output.

Preview

BOOTSTRAP_TRACING=debug ./x test library/std --dry-run

With tracing-forest (this PR), it looks like

Screenshot 2025-06-29 174802

With tracing-tree (before this PR), it looked like

Screenshot 2025-06-29 175227

r? @Kobzol

@jieyouxu
Use tracing-forest instead of tracing-tree for bootstrap tracing
0cb0b22 
I find the `tracing-forest` output easier to comprehend.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 29, 2025
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
warning: spurious network error (3 tries remaining): [7] Could not connect to server (Failed to connect to index.crates.io port 443 after 16382 ms: Could not connect to server)
error: failed to get `dlmalloc` as a dependency of package `std v0.0.0 (/checkout/library/std)`

Caused by:
  download of dl/ma/dlmalloc failed

Caused by:
  failed to download from `https://index.crates.io/dl/ma/dlmalloc`

Caused by:
  [7] Could not connect to server (Failed to connect to index.crates.io port 443 after 8219 ms: Could not connect to server)
Build completed unsuccessfully in 0:04:25
  local time: Sun Jun 29 10:08:13 UTC 2025

@jieyouxu jieyouxu closed this Jun 29, 2025
@jieyouxu jieyouxu reopened this Jun 29, 2025
@Kobzol
Copy link
Member

Kobzol commented Jun 30, 2025

Thanks! Neither is perfect, but I find the forest output easier to read, especially to figure out the child-parent relationships.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 30, 2025

📌 Commit 0cb0b22 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 30, 2025
Merged
bors added a commit that referenced this pull request Jun 30, 2025
@bors
Auto merge of #143254 - matthiaskrgr:rollup-7x8bxek, r=matthiaskrgr
fdad98d 
Rollup of 9 pull requests

Successful merges:

 - #143019 (Ensure -V --verbose processes both codegen_backend and codegen-backend)
 - #143140 (give Pointer::into_parts a more scary name and offer a safer alternative)
 - #143175 (Make combining LLD with external LLVM config a hard error)
 - #143180 (Use `tracing-forest` instead of `tracing-tree` for bootstrap tracing)
 - #143223 (Improve macro stats printing)
 - #143228 (Handle build scripts better in `-Zmacro-stats` output.)
 - #143229 ([COMPILETEST-UNTANGLE 1/N] Move some some early config checks to the lib and move the compiletest binary)
 - #143246 (Subtree update of `rust-analyzer`)
 - #143248 (Update books)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d3c02b4 into rust-lang:master Jul 1, 2025
13 of 20 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 1, 2025
rust-timer added a commit that referenced this pull request Jul 1, 2025
@rust-timer
Unrolled build for #143180
674cad4 
Rollup merge of #143180 - jieyouxu:forest, r=Kobzol

Use `tracing-forest` instead of `tracing-tree` for bootstrap tracing

I find the `tracing-forest` output easier to comprehend.

Note that this is not a strict improvement -- `tracing-forest` output contains some emojis and redundant log levels, but customizing it seems to be... non-trivial. Despite this, I still find `tracing-forest` easier to follow than `tracing-tree`, even when I tried to tune `tracing-tree` output.

### Preview

```bash
BOOTSTRAP_TRACING=debug ./x test library/std --dry-run
```

With `tracing-forest` (this PR), it looks like

![Screenshot 2025-06-29 174802](https://github.com/user-attachments/assets/1ab9150f-48f8-4fb3-b004-27bcf8bbc0f5)

With `tracing-tree` (before this PR), it looked like

![Screenshot 2025-06-29 175227](https://github.com/user-attachments/assets/659e254d-15ab-47dd-af11-98e2331d4d7a)

r? `@Kobzol`
@jieyouxu jieyouxu deleted the forest branch July 1, 2025 03:15
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jul 1, 2025
@bors
Auto merge of #143254 - matthiaskrgr:rollup-7x8bxek, r=matthiaskrgr
efec694 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#143019 (Ensure -V --verbose processes both codegen_backend and codegen-backend)
 - rust-lang/rust#143140 (give Pointer::into_parts a more scary name and offer a safer alternative)
 - rust-lang/rust#143175 (Make combining LLD with external LLVM config a hard error)
 - rust-lang/rust#143180 (Use `tracing-forest` instead of `tracing-tree` for bootstrap tracing)
 - rust-lang/rust#143223 (Improve macro stats printing)
 - rust-lang/rust#143228 (Handle build scripts better in `-Zmacro-stats` output.)
 - rust-lang/rust#143229 ([COMPILETEST-UNTANGLE 1/N] Move some some early config checks to the lib and move the compiletest binary)
 - rust-lang/rust#143246 (Subtree update of `rust-analyzer`)
 - rust-lang/rust#143248 (Update books)

r? `@ghost`
`@rustbot` modify labels: rollup
antoyo pushed a commit to rust-lang/rustc_codegen_gcc that referenced this pull request Jul 12, 2025
@bors
Auto merge of #143254 - matthiaskrgr:rollup-7x8bxek, r=matthiaskrgr
44b7484 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#143019 (Ensure -V --verbose processes both codegen_backend and codegen-backend)
 - rust-lang/rust#143140 (give Pointer::into_parts a more scary name and offer a safer alternative)
 - rust-lang/rust#143175 (Make combining LLD with external LLVM config a hard error)
 - rust-lang/rust#143180 (Use `tracing-forest` instead of `tracing-tree` for bootstrap tracing)
 - rust-lang/rust#143223 (Improve macro stats printing)
 - rust-lang/rust#143228 (Handle build scripts better in `-Zmacro-stats` output.)
 - rust-lang/rust#143229 ([COMPILETEST-UNTANGLE 1/N] Move some some early config checks to the lib and move the compiletest binary)
 - rust-lang/rust#143246 (Subtree update of `rust-analyzer`)
 - rust-lang/rust#143248 (Update books)

r? `@ghost`
`@rustbot` modify labels: rollup
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Jul 15, 2025
@bors
Auto merge of #143254 - matthiaskrgr:rollup-7x8bxek, r=matthiaskrgr
5329163 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#143019 (Ensure -V --verbose processes both codegen_backend and codegen-backend)
 - rust-lang/rust#143140 (give Pointer::into_parts a more scary name and offer a safer alternative)
 - rust-lang/rust#143175 (Make combining LLD with external LLVM config a hard error)
 - rust-lang/rust#143180 (Use `tracing-forest` instead of `tracing-tree` for bootstrap tracing)
 - rust-lang/rust#143223 (Improve macro stats printing)
 - rust-lang/rust#143228 (Handle build scripts better in `-Zmacro-stats` output.)
 - rust-lang/rust#143229 ([COMPILETEST-UNTANGLE 1/N] Move some some early config checks to the lib and move the compiletest binary)
 - rust-lang/rust#143246 (Subtree update of `rust-analyzer`)
 - rust-lang/rust#143248 (Update books)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Kobzol Kobzol

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jieyouxu @rust-log-analyzer @Kobzol @bors @rustbot