Skip to content

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jun 28, 2025

7 commits in 409fed7dc1553d49cb9a8c0637d12d65571346ce..930b4f62cfcd1f0eabdb30a56d91bf6844b739bf
2025-06-23 15:55:04 +0000 to 2025-06-28 14:58:43 +0000

@ehuss ehuss self-assigned this Jun 28, 2025
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 28, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 28, 2025

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

@ehuss
Copy link
Contributor Author

ehuss commented Jun 28, 2025

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Jun 28, 2025

📌 Commit e0c8c3f has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2025
@bors
Copy link
Collaborator

bors commented Jun 29, 2025

⌛ Testing commit e0c8c3f with merge 8141c22...

@bors
Copy link
Collaborator

bors commented Jun 29, 2025

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 8141c22 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 29, 2025
@bors bors merged commit 8141c22 into rust-lang:master Jun 29, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jun 29, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing cf38b8e (parent) -> 8141c22 (this PR)

Test differences

Show 4 test diffs

Stage 2

  • cross_compile::doctest_xcompile_linker: ignore (waiting for 1.88 to be stable for doctest xcompile flags) -> pass (J0)
  • test::cargo_test_doctest_xcompile_ignores: ignore (waiting for 1.88 to be stable for doctest xcompile flags) -> pass (J0)
  • test::cargo_test_doctest_xcompile_no_runner: ignore (waiting for 1.88 to be stable for doctest xcompile flags) -> pass (J0)
  • test::cargo_test_doctest_xcompile_runner: ignore (waiting for 1.88 to be stable for doctest xcompile flags) -> pass (J0)

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 8141c2265f5f2b26d89abe8df5fa67286f2425d4 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 5558.9s -> 6610.1s (18.9%)
  2. mingw-check-1: 1651.1s -> 1842.0s (11.6%)
  3. aarch64-apple: 4236.0s -> 4703.9s (11.0%)
  4. x86_64-apple-2: 5193.3s -> 5668.2s (9.1%)
  5. x86_64-msvc-ext2: 5774.1s -> 5351.7s (-7.3%)
  6. mingw-check-2: 2002.7s -> 2120.0s (5.9%)
  7. x86_64-gnu-nopt: 7072.1s -> 7440.0s (5.2%)
  8. x86_64-msvc-ext1: 6855.0s -> 7189.6s (4.9%)
  9. dist-aarch64-linux: 5727.2s -> 6005.6s (4.9%)
  10. x86_64-gnu-tools: 3474.7s -> 3636.2s (4.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8141c22): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.4%, secondary -6.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.4% [1.4%, 1.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-6.4% [-6.4%, -6.4%] 1
All ❌✅ (primary) 1.4% [1.4%, 1.4%] 1

Cycles

Results (secondary -3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.1% [-3.5%, -2.6%] 5
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 693.692s -> 693.957s (0.04%)
Artifact size: 371.73 MiB -> 371.70 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants