Port #[no_mangle] to new attribute parsing infrastructure
#142823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
A-attributes
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred in compiler/rustc_codegen_ssa Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred in compiler/rustc_attr_data_structures Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs Some changes occurred in compiler/rustc_attr_parsing rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
JonathanBrouwer
commented
Jun 21, 2025
9 tasks
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
force-pushed
the
no_mangle_parser
branch
from
1735b54 to
db15940
Compare
This comment has been minimized.
This comment has been minimized.
rustbot
added
has-merge-commits
JonathanBrouwer
force-pushed
the
no_mangle_parser
branch
from
db15940 to
df4ad9e
Compare
rustbot
removed
S-waiting-on-author
|
Woops I accidentally rebased on the wrong commit and git did not like that, should be good now :P |
This comment has been minimized.
This comment has been minimized.
|
r=me after that and ci |
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
JonathanBrouwer
force-pushed
the
no_mangle_parser
branch
from
ed3740a to
ae3ece2
Compare
|
rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi These commits modify Please ensure that if you've changed the output:
|
rustbot
added
the
S-waiting-on-author
|
☔ The latest upstream changes (presumably #142826) made this pull request unmergeable. Please resolve the merge conflicts. |
JonathanBrouwer
force-pushed
the
no_mangle_parser
branch
from
628e1ee to
f54545e
Compare
rustbot
added
S-waiting-on-review
JonathanBrouwer
force-pushed
the
no_mangle_parser
branch
from
f54545e to
d7a5d0a
Compare
|
Rebased to solve merge conflicts |
Signed-off-by: Jonathan Brouwer <[email protected]>
JonathanBrouwer
force-pushed
the
no_mangle_parser
branch
from
d7a5d0a to
2084831
Compare
|
Rebased to solve merge conflicts |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 22, 2025
…r=jdonszelmann Port `#[no_mangle]` to new attribute parsing infrastructure Ports `no_mangle` to the new attribute parsing infrastructure for rust-lang#131229 (comment) r? `@jdonszelmann`
bors
added a commit
that referenced
this pull request
Jun 23, 2025
Rollup of 6 pull requests Successful merges: - #140136 (Add an aarch64-msvc build running on ARM64 Windows) - #141597 (Document subdirectories of UI tests with README files) - #142823 (Port `#[no_mangle]` to new attribute parsing infrastructure) - #142828 (1.88.0 release notes) - #142854 (centralize `-Zmin-function-alignment` logic) - #142875 (Check rustdoc-json-types FORMAT_VERSION is correctly updated) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Jun 23, 2025
Rollup of 5 pull requests Successful merges: - #141597 (Document subdirectories of UI tests with README files) - #142823 (Port `#[no_mangle]` to new attribute parsing infrastructure) - #142828 (1.88.0 release notes) - #142854 (centralize `-Zmin-function-alignment` logic) - #142875 (Check rustdoc-json-types FORMAT_VERSION is correctly updated) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 23, 2025
Rollup merge of #142823 - JonathanBrouwer:no_mangle_parser, r=jdonszelmann Port `#[no_mangle]` to new attribute parsing infrastructure Ports `no_mangle` to the new attribute parsing infrastructure for #131229 (comment) r? ``@jdonszelmann``
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Jun 23, 2025
…t, r=jdonszelmann Fix comment on NoMangle Fix comment on NoMangle. This was discussed in comments of rust-lang#142823 (comment) and rust-lang#142921
rust-timer
added a commit
that referenced
this pull request
Jun 24, 2025
Rollup merge of #142922 - JonathanBrouwer:fix-rustdoc-comment, r=jdonszelmann Fix comment on NoMangle Fix comment on NoMangle. This was discussed in comments of #142823 (comment) and #142921
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jun 26, 2025
Rollup of 5 pull requests Successful merges: - rust-lang/rust#141597 (Document subdirectories of UI tests with README files) - rust-lang/rust#142823 (Port `#[no_mangle]` to new attribute parsing infrastructure) - rust-lang/rust#142828 (1.88.0 release notes) - rust-lang/rust#142854 (centralize `-Zmin-function-alignment` logic) - rust-lang/rust#142875 (Check rustdoc-json-types FORMAT_VERSION is correctly updated) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports
no_mangleto the new attribute parsing infrastructure for #131229 (comment)r? @jdonszelmann