Specify NO_LLVM_ASSERTIONS for *-nopt jobs
#142516
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without `NO_LLVM_ASSERTIONS=1`, the `*-nopt` jobs will by default receive configure arg `--enable-llvm-assertions`.
rustbot
added
A-testsuite
|
cc @Kobzol: do you have any ideas why when |
|
No idea, I'll take a look on Monday. |
|
r? Kobzol |
|
I think it will be the recent-ish changes around merging configs. The empty config overrides LLVM assertions, and probably half of the rest of the CI options. We shouldn't use |
|
Proper fix is #142566. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without
NO_LLVM_ASSERTIONS=1, the*-noptjobs will by default receive configure arg--enable-llvm-assertionsbut then cmake also receives-DLLVM_ENABLE_ASSERTIONS=OFF.Tested in #142504.
Unblocks #142447.
r? infra-ci