Do not checkout GCC submodule for the tidy job #142211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
Kobzol
force-pushed
the
try-fast-submodule-checkout
branch
from
b3b6f8e to
579c553
Compare
This comment has been minimized.
This comment has been minimized.
Kobzol
force-pushed
the
try-fast-submodule-checkout
branch
2 times, most recently
from
02cda66 to
e2f3c4c
Compare
Kobzol
changed the title
Kobzol
force-pushed
the
try-fast-submodule-checkout
branch
from
e2f3c4c to
224bad9
Compare
|
r? @marcoieni rustbot has assigned @marcoieni. Use |
rustbot
added
the
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
Kobzol
force-pushed
the
try-fast-submodule-checkout
branch
from
224bad9 to
cb99801
Compare
|
Rebased. @bors r=Mark-Simulacrum |
|
@bors rollup=always |
bors
added a commit
that referenced
this pull request
Jun 9, 2025
Rollup of 6 pull requests Successful merges: - #141751 (Remap compiler vs non-compiler sources differently (bootstrap side)) - #142160 (Only allow `bootstrap` cfg in rustc & related) - #142191 (early return in trait detection for non-trait item) - #142211 (Do not checkout GCC submodule for the tidy job) - #142218 (CI: rfl: move job forward to Linux v6.16-rc1) - #142224 (Avoid a gratuitous 10s wait in a stress test) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 9, 2025
Rollup merge of #142211 - Kobzol:try-fast-submodule-checkout, r=Mark-Simulacrum Do not checkout GCC submodule for the tidy job This is not a fully general solution, but the GCC submodule checkout is so slow that I think it's worth it to special-case it. This brings down the time required to checkout submodules from ~1.5 minute to ~0.5 minute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a fully general solution, but the GCC submodule checkout is so slow that I think it's worth it to special-case it. This brings down the time required to checkout submodules from ~1.5 minute to ~0.5 minute.