Skip to content

Conversation

LukeMathWalker
Copy link
Contributor

@LukeMathWalker LukeMathWalker commented Jun 2, 2025

This allows consumers to create collections that require an ordering relationship for their keys—e.g. a BTreeMap.

@rustbot
Copy link
Collaborator

rustbot commented Jun 2, 2025

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 2, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 2, 2025

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi

@aDotInTheVoid
Copy link
Member

r? @aDotInTheVoid

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 2, 2025

📌 Commit 6be3c3c has been approved by aDotInTheVoid

It is now in the queue for this repository.

@rustbot rustbot assigned aDotInTheVoid and unassigned notriddle Jun 2, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2025
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 3, 2025
…eVoid

[rustdoc-json] Implement PartialOrd and Ord for rustdoc_types::Id

This allows consumers to create collections that required an ordering relationship for their keys—e.g. a `BTreeMap`.
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 3, 2025
…eVoid

[rustdoc-json] Implement PartialOrd and Ord for rustdoc_types::Id

This allows consumers to create collections that required an ordering relationship for their keys—e.g. a `BTreeMap`.
bors added a commit that referenced this pull request Jun 3, 2025
Rollup of 9 pull requests

Successful merges:

 - #141554 (Improve documentation for codegen options)
 - #141817 (rustc_llvm: add Windows system libs only when cross-compiling from Wi…)
 - #141843 (Add `visit_id` to ast `Visitor`)
 - #141881 (Subtree update of `rust-analyzer`)
 - #141898 ([rustdoc-json] Implement PartialOrd and Ord for rustdoc_types::Id)
 - #141921 (Disable f64 minimum/maximum tests for arm 32)
 - #141930 (Enable triagebot `[concern]` functionality)
 - #141936 (Decouple "reporting in deps" from `FutureIncompatibilityReason`)
 - #141949 (move `test-float-parse` tool into `src/tools` dir)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8fbf365 into rust-lang:master Jun 3, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 3, 2025
rust-timer added a commit that referenced this pull request Jun 3, 2025
Rollup merge of #141898 - LukeMathWalker:patch-1, r=aDotInTheVoid

[rustdoc-json] Implement PartialOrd and Ord for rustdoc_types::Id

This allows consumers to create collections that required an ordering relationship for their keys—e.g. a `BTreeMap`.
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Jun 9, 2025
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#141554 (Improve documentation for codegen options)
 - rust-lang/rust#141817 (rustc_llvm: add Windows system libs only when cross-compiling from Wi…)
 - rust-lang/rust#141843 (Add `visit_id` to ast `Visitor`)
 - rust-lang/rust#141881 (Subtree update of `rust-analyzer`)
 - rust-lang/rust#141898 ([rustdoc-json] Implement PartialOrd and Ord for rustdoc_types::Id)
 - rust-lang/rust#141921 (Disable f64 minimum/maximum tests for arm 32)
 - rust-lang/rust#141930 (Enable triagebot `[concern]` functionality)
 - rust-lang/rust#141936 (Decouple "reporting in deps" from `FutureIncompatibilityReason`)
 - rust-lang/rust#141949 (move `test-float-parse` tool into `src/tools` dir)

r? `@ghost`
`@rustbot` modify labels: rollup
tautschnig pushed a commit to model-checking/verify-rust-std that referenced this pull request Jun 17, 2025
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#141554 (Improve documentation for codegen options)
 - rust-lang#141817 (rustc_llvm: add Windows system libs only when cross-compiling from Wi…)
 - rust-lang#141843 (Add `visit_id` to ast `Visitor`)
 - rust-lang#141881 (Subtree update of `rust-analyzer`)
 - rust-lang#141898 ([rustdoc-json] Implement PartialOrd and Ord for rustdoc_types::Id)
 - rust-lang#141921 (Disable f64 minimum/maximum tests for arm 32)
 - rust-lang#141930 (Enable triagebot `[concern]` functionality)
 - rust-lang#141936 (Decouple "reporting in deps" from `FutureIncompatibilityReason`)
 - rust-lang#141949 (move `test-float-parse` tool into `src/tools` dir)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants