- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
rustc-dev-guide subtree update #141894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            rustc-dev-guide subtree update #141894
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Normally I refrain from nit picking, but this seamed worth it.
Small typo and style fixes in binders.md
The order might have been reversed at some point, leading to the two chapters talking about each other in the wrong order.
Fix misdirected link for `TypingEnv`
Update links between ty-module and binders
Make it clear we talk about early bound params
It does not do any line matching, so it should be separated from the other types.
Now that CI has been finally migrated to `rust-lang/rust`.
document why rustdoc cannot look at function bodies
rustdoc.md: reorder list so test suites are not split up
…-lang-ci Remove mentions of rust-lang-ci/rust
Update `rustc_on_unimplemented` docs
…s-yes Flesh out sections about crashes tests and update mentions of glacier
Link normalization chapter
Add time reference and tracking info for trait system refactor
This effort is blocked, so pointing new contributors here would be setting them up for failure. https://rust-lang.zulipchat.com/#narrow/channel/266220-t-rustdoc/topic/about.3A.20status.20of.20askama.20migration/with/497389045
replace a broken sentence
suggest build/rust-analyzer instead of build-rust-analyzer
update surname (was lekhonkhobe previously) and email
This allows for the code to compile on `nightly`.
There is no `foo` symbol in the preceding example. I assume the method `bar` is meant.
Trivial: fix typo (change `foo` to `bar`)
Rustc pull update
Add opaque type attributes
Fix link to GatherBorrows
| The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. | 
              
                    jieyouxu
  
              
              approved these changes
              
                  
                    Jun 2, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
| r? jieyouxu @bors r+ rollup | 
    
  bors 
      added a commit
      that referenced
      this pull request
    
      Jun 2, 2025 
    
    
      
  
    
      
    
  
Rollup of 6 pull requests Successful merges: - #141884 (allow macro_use as first segment) - #141885 ([RTE-484] Update SGX maintainers) - #141892 (Fix false positive lint error from no_implicit_prelude attr) - #141894 (rustc-dev-guide subtree update) - #141895 (tshepang has a new email) - #141897 (Fix citool tests when executed locally) r? `@ghost` `@rustbot` modify labels: rollup
    
  rust-timer 
      added a commit
      that referenced
      this pull request
    
      Jun 2, 2025 
    
    
      
  
    
      
    
  
Rollup merge of #141894 - tshepang:rdg-push, r=jieyouxu rustc-dev-guide subtree update r? `@ghost`
    
  jieyouxu 
      pushed a commit
        to jieyouxu/rustc-dev-guide
      that referenced
      this pull request
    
      Jun 3, 2025 
    
    
      
  
    
      
    
  
Rollup of 6 pull requests Successful merges: - rust-lang/rust#141884 (allow macro_use as first segment) - rust-lang/rust#141885 ([RTE-484] Update SGX maintainers) - rust-lang/rust#141892 (Fix false positive lint error from no_implicit_prelude attr) - rust-lang/rust#141894 (rustc-dev-guide subtree update) - rust-lang/rust#141895 (tshepang has a new email) - rust-lang/rust#141897 (Fix citool tests when executed locally) r? `@ghost` `@rustbot` modify labels: rollup
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    A-rustc-dev-guide
  Area: rustc-dev-guide 
  
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
r? @ghost