- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
          Add missing dyn keywords to tests that do not test for them
          #141889
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    This ensures that these tests can be run on editions other than 2015
| rustbot has assigned @petrochenkov. Use  | 
| @bors r+ | 
    
  matthiaskrgr 
      added a commit
        to matthiaskrgr/rust
      that referenced
      this pull request
    
      Jun 2, 2025 
    
    
      
  
    
      
    
  
…rochenkov Add missing `dyn` keywords to tests that do not test for them This ensures that these tests can be run on editions other than 2015
    
  matthiaskrgr 
      added a commit
        to matthiaskrgr/rust
      that referenced
      this pull request
    
      Jun 2, 2025 
    
    
      
  
    
      
    
  
…rochenkov Add missing `dyn` keywords to tests that do not test for them This ensures that these tests can be run on editions other than 2015
    
  workingjubilee 
      added a commit
        to workingjubilee/rustc
      that referenced
      this pull request
    
      Jun 3, 2025 
    
    
      
  
    
      
    
  
…rochenkov Add missing `dyn` keywords to tests that do not test for them This ensures that these tests can be run on editions other than 2015
    
  workingjubilee 
      added a commit
        to workingjubilee/rustc
      that referenced
      this pull request
    
      Jun 3, 2025 
    
    
      
  
    
      
    
  
…rochenkov Add missing `dyn` keywords to tests that do not test for them This ensures that these tests can be run on editions other than 2015
    
  bors 
      added a commit
      that referenced
      this pull request
    
      Jun 3, 2025 
    
    
      
  
    
      
    
  
Rollup of 8 pull requests Successful merges: - #140715 (Clarify &mut-methods' docs on sync::OnceLock) - #141677 (Async drop - type instead of async drop fn, fixes #140484) - #141741 (Overhaul `UsePath`) - #141873 (Fixed a typo in `ManuallyDrop`'s doc) - #141876 (Don't declare variables in `ExprKind::Let` in invalid positions) - #141886 (Add missing 2015 edition directives) - #141889 (Add missing `dyn` keywords to tests that do not test for them) - #141891 (Fix borrowck mentioning a name from an external macro we (deliberately) don't save) r? `@ghost` `@rustbot` modify labels: rollup
    
  rust-timer 
      added a commit
      that referenced
      this pull request
    
      Jun 3, 2025 
    
    
      
  
    
      
    
  
Rollup merge of #141889 - ferrocene:lw/missing-dyn-kw, r=petrochenkov Add missing `dyn` keywords to tests that do not test for them This ensures that these tests can be run on editions other than 2015
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  
    T-compiler
  Relevant to the compiler team, which will review and decide on the PR/issue. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This ensures that these tests can be run on editions other than 2015