Skip to content

Conversation

compiler-errors
Copy link
Member

Fixes #141422.

The other two binder-having types are also special cased here, unsurprisingly.

r? oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 23, 2025

Some changes occurred in match checking

cc @Nadrieril

@compiler-errors compiler-errors force-pushed the unsafe-binder-non-structural-match branch from 00952f9 to 46606a3 Compare May 23, 2025 10:10
@spastorino
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 23, 2025

📌 Commit 46606a3 has been approved by spastorino

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 23, 2025
…structural-match, r=spastorino

Dont walk into unsafe binders when emiting error for non-structural type match

Fixes rust-lang#141422.

The other two binder-having types are also special cased here, unsurprisingly.

r? oli-obk
bors added a commit that referenced this pull request May 24, 2025
Rollup of 8 pull requests

Successful merges:

 - #140790 (Enable xray support for Mac)
 - #141405 (GetUserProfileDirectoryW is now documented to always store the size)
 - #141413 (Make #[cfg(version)] respect RUSTC_OVERRIDE_VERSION_STRING)
 - #141427 (Disable `triagebot`'s `glacier` handler)
 - #141429 (Dont walk into unsafe binders when emiting error for non-structural type match)
 - #141438 (Do not try to confirm non-dyn compatible method)
 - #141444 (Improve CONTRIBUTING.md grammar and clarity)
 - #141446 (Add 2nd Solaris target maintainer)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 24, 2025
…structural-match, r=spastorino

Dont walk into unsafe binders when emiting error for non-structural type match

Fixes rust-lang#141422.

The other two binder-having types are also special cased here, unsurprisingly.

r? oli-obk
bors added a commit that referenced this pull request May 24, 2025
Rollup of 7 pull requests

Successful merges:

 - #141405 (GetUserProfileDirectoryW is now documented to always store the size)
 - #141427 (Disable `triagebot`'s `glacier` handler)
 - #141429 (Dont walk into unsafe binders when emiting error for non-structural type match)
 - #141438 (Do not try to confirm non-dyn compatible method)
 - #141444 (Improve CONTRIBUTING.md grammar and clarity)
 - #141446 (Add 2nd Solaris target maintainer)
 - #141456 (Suggest correct `version("..")` predicate syntax in check-cfg)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 293977a into rust-lang:master May 24, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 24, 2025
rust-timer added a commit that referenced this pull request May 24, 2025
Rollup merge of #141429 - compiler-errors:unsafe-binder-non-structural-match, r=spastorino

Dont walk into unsafe binders when emiting error for non-structural type match

Fixes #141422.

The other two binder-having types are also special cased here, unsurprisingly.

r? oli-obk
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request May 26, 2025
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#141405 (GetUserProfileDirectoryW is now documented to always store the size)
 - rust-lang#141427 (Disable `triagebot`'s `glacier` handler)
 - rust-lang#141429 (Dont walk into unsafe binders when emiting error for non-structural type match)
 - rust-lang#141438 (Do not try to confirm non-dyn compatible method)
 - rust-lang#141444 (Improve CONTRIBUTING.md grammar and clarity)
 - rust-lang#141446 (Add 2nd Solaris target maintainer)
 - rust-lang#141456 (Suggest correct `version("..")` predicate syntax in check-cfg)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: has escaping bound vars, so it cannot be wrapped in a dummy binder with unsafe_binders
5 participants