Skip to content

Conversation

aDotInTheVoid
Copy link
Member

The docs about how #[inline] was represented isn't true. Updates the comment, and adds a test.

CC #137645

r? @GuillaumeGomez

The docs about how `#[inline]` was represented isn't true. Updates the
comment, and adds a test.

CC https://www.github.com/rust-lang/rust/issues/137645
@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels May 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 21, 2025

These commits modify tests/rustdoc-json.
rustdoc-json is a public (but unstable) interface.

Please ensure that if you've changed the output:

  • It's intentional.
  • The FORMAT_VERSION in src/librustdoc-json-types is bumped if necessary.

cc @aDotInTheVoid, @obi1kenobi

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi

@GuillaumeGomez
Copy link
Member

Thanks!

r=me once CI pass

@aDotInTheVoid
Copy link
Member Author

@bors r=GuillaumeGomez rollup

@bors
Copy link
Collaborator

bors commented May 21, 2025

📌 Commit 8cdfabd has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 22, 2025
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#140431 (dont handle bool transmute)
 - rust-lang#140868 (rustdoc: Fix links with inline code in trait impl docs)
 - rust-lang#141323 (Add bors environment to CI)
 - rust-lang#141337 (bump stdarch)
 - rust-lang#141364 (rustdoc-json: Remove false docs and add test for inline attribute)
 - rust-lang#141370 (add doc alias `replace_first` for `str::replacen`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 79f0a97 into rust-lang:master May 22, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 22, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 22, 2025
Rollup merge of rust-lang#141364 - aDotInTheVoid:atttrdocss, r=GuillaumeGomez

rustdoc-json: Remove false docs and add test for inline attribute

The docs about how `#[inline]` was represented isn't true. Updates the comment, and adds a test.

CC rust-lang#137645

r? `@GuillaumeGomez`
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request May 26, 2025
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#140431 (dont handle bool transmute)
 - rust-lang#140868 (rustdoc: Fix links with inline code in trait impl docs)
 - rust-lang#141323 (Add bors environment to CI)
 - rust-lang#141337 (bump stdarch)
 - rust-lang#141364 (rustdoc-json: Remove false docs and add test for inline attribute)
 - rust-lang#141370 (add doc alias `replace_first` for `str::replacen`)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants