Skip to content

Conversation

ChrisDenton
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

mejrs and others added 30 commits April 9, 2025 21:45
Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
@ChrisDenton
Copy link
Member Author

seems spurious

@bors retry couldn't create a temp dir: Access is denied

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2025
@bors
Copy link
Collaborator

bors commented Apr 20, 2025

⌛ Testing commit f0a0efd with merge 69021b9...

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 20, 2025
…enton

Rollup of 8 pull requests

Successful merges:

 - rust-lang#138934 (support config extensions)
 - rust-lang#139091 (Rewrite on_unimplemented format string parser.)
 - rust-lang#139753 (Make `#[naked]` an unsafe attribute)
 - rust-lang#139762 (Don't assemble non-env/bound candidates if projection is rigid)
 - rust-lang#139834 (Don't canonicalize crate paths)
 - rust-lang#139868 (Move `pal::env` to `std::sys::env_consts`)
 - rust-lang#139978 (Add citool command for generating a test dashboard)
 - rust-lang#139995 (Clean UI tests 4 of n)

r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
Copy link
Collaborator

The job dist-loongarch64-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Apr 20, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 20, 2025
@ChrisDenton
Copy link
Member Author

@bors retry network error

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2025
@bors
Copy link
Collaborator

bors commented Apr 20, 2025

⌛ Testing commit f0a0efd with merge 49e5e4e...

@bors
Copy link
Collaborator

bors commented Apr 20, 2025

☀️ Test successful - checks-actions
Approved by: ChrisDenton
Pushing 49e5e4e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 20, 2025
@bors bors merged commit 49e5e4e into rust-lang:master Apr 20, 2025
7 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 20, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 90fd16e (parent) -> 49e5e4e (this PR)

Test differences

Show 83 test diffs

Stage 0

  • core::config::tests::test_cyclic_include_direct: [missing] -> pass (J0)
  • core::config::tests::test_cyclic_include_indirect: [missing] -> pass (J0)
  • core::config::tests::test_include_absolute_paths: [missing] -> pass (J0)
  • core::config::tests::test_include_precedence_over_profile: [missing] -> pass (J0)
  • core::config::tests::test_include_relative_paths: [missing] -> pass (J0)
  • core::config::tests::test_precedence_of_includes: [missing] -> pass (J0)

Stage 1

  • error_reporting::traits::on_unimplemented::verify_trait_selection_disallowed_positional_argument_4: pass -> [missing] (J0)
  • error_reporting::traits::on_unimplemented::verify_trait_selection_invalid_format_specifier_5: pass -> [missing] (J0)
  • error_reporting::traits::on_unimplemented::verify_trait_selection_unknown_format_parameter_for_on_unimplemented_attr_3: pass -> [missing] (J0)
  • error_reporting::traits::on_unimplemented::verify_trait_selection_wrapped_parser_error_3: [missing] -> pass (J0)
  • error_reporting::traits::on_unimplemented::verify_trait_selection_wrapped_parser_error_6: pass -> [missing] (J0)
  • error_reporting::traits::on_unimplemented_format::errors::verify_trait_selection_disallowed_positional_argument_5: [missing] -> pass (J0)
  • error_reporting::traits::on_unimplemented_format::errors::verify_trait_selection_ignored_diagnostic_option_8: [missing] -> pass (J0)
  • error_reporting::traits::on_unimplemented_format::errors::verify_trait_selection_invalid_format_specifier_6: [missing] -> pass (J0)
  • error_reporting::traits::on_unimplemented_format::errors::verify_trait_selection_missing_options_for_on_unimplemented_attr_7: [missing] -> pass (J0)
  • error_reporting::traits::on_unimplemented_format::errors::verify_trait_selection_unknown_format_parameter_for_on_unimplemented_attr_4: [missing] -> pass (J0)
  • errors::verify_trait_selection_async_closure_not_fn_12: pass -> [missing] (J0)
  • errors::verify_trait_selection_async_closure_not_fn_14: [missing] -> pass (J0)
  • errors::verify_trait_selection_but_calling_introduces_15: pass -> [missing] (J0)
  • errors::verify_trait_selection_but_calling_introduces_17: [missing] -> pass (J0)
  • errors::verify_trait_selection_but_needs_to_satisfy_16: pass -> [missing] (J0)
  • errors::verify_trait_selection_but_needs_to_satisfy_18: [missing] -> pass (J0)
  • errors::verify_trait_selection_empty_on_clause_in_rustc_on_unimplemented_10: [missing] -> pass (J0)
  • errors::verify_trait_selection_empty_on_clause_in_rustc_on_unimplemented_8: pass -> [missing] (J0)
  • errors::verify_trait_selection_explicit_lifetime_required_with_ident_13: pass -> [missing] (J0)
  • errors::verify_trait_selection_explicit_lifetime_required_with_ident_15: [missing] -> pass (J0)
  • errors::verify_trait_selection_explicit_lifetime_required_with_param_type_14: pass -> [missing] (J0)
  • errors::verify_trait_selection_explicit_lifetime_required_with_param_type_16: [missing] -> pass (J0)
  • errors::verify_trait_selection_inherent_projection_normalization_overflow_11: pass -> [missing] (J0)
  • errors::verify_trait_selection_inherent_projection_normalization_overflow_13: [missing] -> pass (J0)
  • errors::verify_trait_selection_invalid_on_clause_in_rustc_on_unimplemented_11: [missing] -> pass (J0)
  • errors::verify_trait_selection_invalid_on_clause_in_rustc_on_unimplemented_9: pass -> [missing] (J0)
  • errors::verify_trait_selection_lf_bound_not_satisfied_17: pass -> [missing] (J0)
  • errors::verify_trait_selection_lf_bound_not_satisfied_18: pass -> [missing] (J0)
  • errors::verify_trait_selection_lf_bound_not_satisfied_22: [missing] -> pass (J0)
  • errors::verify_trait_selection_lf_bound_not_satisfied_23: [missing] -> pass (J0)
  • errors::verify_trait_selection_no_value_in_rustc_on_unimplemented_10: pass -> [missing] (J0)
  • errors::verify_trait_selection_no_value_in_rustc_on_unimplemented_12: [missing] -> pass (J0)
  • errors::verify_trait_selection_opaque_captures_lifetime_22: pass -> [missing] (J0)
  • errors::verify_trait_selection_opaque_captures_lifetime_24: [missing] -> pass (J0)
  • errors::verify_trait_selection_opaque_type_non_generic_param_23: pass -> [missing] (J0)
  • errors::verify_trait_selection_opaque_type_non_generic_param_25: [missing] -> pass (J0)
  • errors::verify_trait_selection_unable_to_construct_constant_value_7: pass -> [missing] (J0)
  • errors::verify_trait_selection_unable_to_construct_constant_value_9: [missing] -> pass (J0)
  • [crashes] tests/crashes/130627.rs: pass -> [missing] (J2)
  • [run-make] tests/run-make/crate-loading-multiple-candidates: [missing] -> pass (J2)
  • [ui] tests/ui/codegen/ref-dyn-trait-in-structs-and-enums.rs: [missing] -> pass (J2)
  • [ui] tests/ui/diagnostic_namespace/on_impl_trait.rs: [missing] -> pass (J2)
  • [ui] tests/ui/issues/issue-14421.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-16939.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-23808.rs: pass -> [missing] (J2)
  • [ui] tests/ui/issues/issue-9719.rs: pass -> [missing] (J2)
  • [ui] tests/ui/lint/dead-code/no-dead-code-for-static-trait-impl.rs: [missing] -> pass (J2)
  • [ui] tests/ui/lint/dead-code/no-dead-code-reexported-types-across-crates.rs: [missing] -> pass (J2)
  • [ui] tests/ui/on-unimplemented/impl-substs.rs: pass -> [missing] (J2)
  • [ui] tests/ui/on-unimplemented/issue-104140.rs: pass -> [missing] (J2)
  • [ui] tests/ui/on-unimplemented/multiple-impls.rs: pass -> [missing] (J2)
  • [ui] tests/ui/on-unimplemented/on-impl.rs: pass -> [missing] (J2)
  • [ui] tests/ui/on-unimplemented/use_self_no_underscore.rs: [missing] -> pass (J2)
  • [ui] tests/ui/traits/next-solver/rpitit-cycle-due-to-rigid.rs: [missing] -> pass (J2)

Stage 2

  • [ui] tests/ui/codegen/ref-dyn-trait-in-structs-and-enums.rs: [missing] -> pass (J1)
  • [ui] tests/ui/diagnostic_namespace/on_impl_trait.rs: [missing] -> pass (J1)
  • [ui] tests/ui/issues/issue-14421.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-16939.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-23808.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-9719.rs: pass -> [missing] (J1)
  • [ui] tests/ui/lint/dead-code/no-dead-code-for-static-trait-impl.rs: [missing] -> pass (J1)
  • [ui] tests/ui/lint/dead-code/no-dead-code-reexported-types-across-crates.rs: [missing] -> pass (J1)
  • [ui] tests/ui/on-unimplemented/impl-substs.rs: pass -> [missing] (J1)
  • [ui] tests/ui/on-unimplemented/issue-104140.rs: pass -> [missing] (J1)
  • [ui] tests/ui/on-unimplemented/multiple-impls.rs: pass -> [missing] (J1)
  • [ui] tests/ui/on-unimplemented/on-impl.rs: pass -> [missing] (J1)
  • [ui] tests/ui/on-unimplemented/use_self_no_underscore.rs: [missing] -> pass (J1)
  • [ui] tests/ui/traits/next-solver/rpitit-cycle-due-to-rigid.rs: [missing] -> pass (J1)
  • [run-make] tests/run-make/crate-loading-multiple-candidates: [missing] -> ignore (ignored when cross-compiling) (J3)
  • [run-make] tests/run-make/crate-loading-multiple-candidates: [missing] -> pass (J4)
  • [crashes] tests/crashes/130627.rs: pass -> [missing] (J5)

Additionally, 6 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

\nRun

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 49e5e4e3a5610c240a717cb99003a5d5d3356679 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 5515.8s -> 6419.4s (16.4%)
  2. dist-aarch64-apple: 5146.5s -> 4684.1s (-9.0%)
  3. dist-apple-various: 8577.9s -> 7950.5s (-7.3%)
  4. dist-x86_64-apple: 9604.8s -> 8948.0s (-6.8%)
  5. x86_64-msvc-1: 8470.2s -> 9030.3s (6.6%)
  6. x86_64-gnu-aux: 5984.0s -> 6348.0s (6.1%)
  7. dist-x86_64-freebsd: 4793.3s -> 5079.5s (6.0%)
  8. aarch64-gnu: 6205.1s -> 6542.5s (5.4%)
  9. dist-ohos: 10036.5s -> 10541.4s (5.0%)
  10. dist-s390x-linux: 5151.1s -> 5389.9s (4.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#138934 support config extensions 931cdac750e498f58fbc997776c5a77970de9dee (link)
#139091 Rewrite on_unimplemented format string parser. 3d954cd0f9c9d7ff57da20bbae0e086308057276 (link)
#139753 Make #[naked] an unsafe attribute c3a4e8495b095d4866974d65920dffed9db074c8 (link)
#139762 Don't assemble non-env/bound candidates if projection is ri… f471582ebdf341288748268fcfb7510fad678e55 (link)
#139834 Don't canonicalize crate paths 07c328a653005afc22842c75280277ddbb96a4f6 (link)
#139868 Move pal::env to std::sys::env_consts 27e88b2b95721f79e523f49b82117bc90a7f9d24 (link)
#139978 Add citool command for generating a test dashboard 77211ddf82c69e4141d6cd80acea9a09f198c913 (link)
#139995 Clean UI tests 4 of n 394c5420f4d41de7ad8cc59254650c7aca2d8e0b (link)

previous master: 90fd16eb5b

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (49e5e4e): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.6% [-1.2%, -0.3%] 19
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.6% [-1.2%, -0.3%] 19

Max RSS (memory usage)

Results (primary -0.5%, secondary 2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.7% [0.4%, 1.2%] 5
Regressions ❌
(secondary)
2.2% [1.4%, 2.6%] 3
Improvements ✅
(primary)
-1.1% [-2.4%, -0.7%] 9
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.5% [-2.4%, 1.2%] 14

Cycles

Results (primary -0.5%, secondary -2.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.6% [0.6%, 0.6%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.7% [-1.0%, -0.4%] 7
Improvements ✅
(secondary)
-2.9% [-2.9%, -2.9%] 1
All ❌✅ (primary) -0.5% [-1.0%, 0.6%] 8

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 770.888s -> 773.64s (0.36%)
Artifact size: 365.04 MiB -> 365.02 MiB (-0.01%)

@ChrisDenton ChrisDenton deleted the rollup-vwf0s9j branch April 20, 2025 09:37
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Apr 20, 2025
…eyouxu

Remove stray newline from post-merge report

[Oops](rust-lang#140043 (comment)) :)

r? jieyouxu
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Apr 20, 2025
…eyouxu

Remove stray newline from post-merge report

[Oops](rust-lang#140043 (comment)) :)

r? jieyouxu
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 20, 2025
Rollup merge of rust-lang#140063 - Kobzol:ci-report-fix-newline, r=jieyouxu

Remove stray newline from post-merge report

[Oops](rust-lang#140043 (comment)) :)

r? jieyouxu
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Apr 22, 2025
…enton

Rollup of 8 pull requests

Successful merges:

 - rust-lang#138934 (support config extensions)
 - rust-lang#139091 (Rewrite on_unimplemented format string parser.)
 - rust-lang#139753 (Make `#[naked]` an unsafe attribute)
 - rust-lang#139762 (Don't assemble non-env/bound candidates if projection is rigid)
 - rust-lang#139834 (Don't canonicalize crate paths)
 - rust-lang#139868 (Move `pal::env` to `std::sys::env_consts`)
 - rust-lang#139978 (Add citool command for generating a test dashboard)
 - rust-lang#139995 (Clean UI tests 4 of n)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool merged-by-bors This PR was explicitly merged by bors. O-hermit Operating System: Hermit O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-wasm Target: WASM (WebAssembly), http://webassembly.org/ O-windows Operating system: Windows PG-exploit-mitigations Project group: Exploit mitigations rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.