transmutability: Short-circuit NFA->DFA #139937
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-run-make
|
This PR modifies cc @jieyouxu |
joshlf
force-pushed
the
transmute-short-circuit-nfa-dfa
branch
from
163e0e2 to
8ba547a
Compare
jswrenn
requested changes
Apr 16, 2025
rustbot
added
S-waiting-on-author
This is a false positive because I previously included upstream commits by accident. Rebasing on the current |
This comment has been minimized.
This comment has been minimized.
joshlf
force-pushed
the
transmute-short-circuit-nfa-dfa
branch
from
8ba547a to
8234605
Compare
rustbot
added
A-compiletest
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
joshlf
force-pushed
the
transmute-short-circuit-nfa-dfa
branch
from
8234605 to
648c6c0
Compare
This comment has been minimized.
This comment has been minimized.
joshlf
force-pushed
the
transmute-short-circuit-nfa-dfa
branch
from
648c6c0 to
71d222a
Compare
This comment has been minimized.
This comment has been minimized.
When an NFA is already a DFA, we short-circuit NFA->DFA conversion, avoiding the need to reconstruct the DFA.
joshlf
force-pushed
the
transmute-short-circuit-nfa-dfa
branch
from
71d222a to
f0be2b1
Compare
rustbot
added
S-waiting-on-review
jieyouxu
removed
the
A-testsuite
jieyouxu
removed
T-bootstrap
|
☔ The latest upstream changes (presumably #140079) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an NFA is already a DFA, we short-circuit NFA->DFA conversion,
avoiding the need to reconstruct the DFA.
r? @jswrenn