Add dianqk to codegen reviewers #139260
Merged
Add dianqk to codegen reviewers #139260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-meta
|
|
|
Welcome aboard! 🎉 @bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 2, 2025
…=Urgau Add dianqk to codegen reviewers Not an expert yet, but I may be able to review some LLVM-related PRs. r? codegen
This was referenced Apr 2, 2025
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 2, 2025
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#138992 (literal pattern lowering: use the pattern's type instead of the literal's in `const_to_pat`) - rust-lang#139211 (interpret: add a version of run_for_validation for &self) - rust-lang#139235 (`AstValidator` tweaks) - rust-lang#139237 (Add a dep kind for use of the anon node with zero dependencies) - rust-lang#139260 (Add dianqk to codegen reviewers) - rust-lang#139264 (Fix two incorrect turbofish suggestions) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 2, 2025
Rollup merge of rust-lang#139260 - dianqk:dianqk-codegen-reviewers, r=Urgau Add dianqk to codegen reviewers Not an expert yet, but I may be able to review some LLVM-related PRs. r? codegen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not an expert yet, but I may be able to review some LLVM-related PRs.
r? codegen