privacy: Visit types and traits in impls in type privacy lints

[petrochenkov]

With one exception to avoid false positives.

Fixes the same issue as #134176.

[rustbot]

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[petrochenkov]

r? compiler

[compiler-errors]

@bors r+ rollup

[bors]

📌 Commit fc76f1b has been approved by compiler-errors

It is now in the queue for this repository.

[compiler-errors]

Needs a rebase b/c ControlFlow became #[must_use] recently. I'll open/close to rerun CI.

[compiler-errors]

@bors r-

[TaKO8Ki]

Hi. After merging #137449, ControlFlow is must_use, so could you fix this issue?

  error: unused `ControlFlow` that must be used
      --> compiler/rustc_privacy/src/lib.rs:1409:13
       |
  1409 |             self.visit_trait(trait_ref.instantiate_identity());
       |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       |
       = note: `-D unused-must-use` implied by `-D warnings`
       = help: to override `-D warnings` add `#[allow(unused_must_use)]`
  help: use `let _ = ...` to ignore the resulting value
       |
  1409 |             let _ = self.visit_trait(trait_ref.instantiate_identity());
       |             +++++++

rollup pull request: #138909

[petrochenkov]

@bors r=compiler-errors

[bors]

📌 Commit f756304 has been approved by compiler-errors

It is now in the queue for this repository.