Skip to content

rustdoc: Properly restore search input placeholder #137055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2025
Merged

rustdoc: Properly restore search input placeholder #137055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/librustdoc/html/static/js/search.js
View file
Open in desktop
Copy link
Member Author

@fmease fmease Feb 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, the minimal fix would be:

  searchState.input.addEventListener("blur", () => {
-     searchState.input.placeholder = searchState.input.origPlaceholder;
+     searchState.input.placeholder = searchState.origPlaceholder;
  });

Original file line number Diff line number Diff line change
Expand Up @@ -5318,8 +5318,9 @@ function registerSearchEvents() {

// @ts-expect-error
searchState.input.addEventListener("blur", () => {
// @ts-expect-error
searchState.input.placeholder = searchState.input.origPlaceholder;
if (window.searchState.input) {
window.searchState.input.placeholder = window.searchState.origPlaceholder;
}
});

// Push and pop states are used to add search results to the browser
Expand Down
Loading