Remove : from stack-protector-heuristics-effect.rs Filecheck Pattern

[mustartt]

With function sections, the assembly label does not necessarily end in :.

Remove trailing : to be more consistent with the rest of the existing Filecheck patterns.

// CHECK-LABEL: local_string_addr_taken
#[no_mangle]
pub fn local_string_addr_taken(f: fn(&String)) {
    let x = String::new();
    f(&x);

[rustbot]

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[amy-kwan]

LGTM.

[workingjubilee]

@bors r+ rollup

[bors]

📌 Commit 142d107 has been approved by workingjubilee

It is now in the queue for this repository.

[matthiaskrgr]

@bors r-
#137019 (comment)

[workingjubilee]

It seems that was indeed load-bearing

[mustartt]

The original FileCheck pattern : is preventing the match against WASM's .functype emptyfn () -> (). Originally, only 4/16 of the check labels have : at the end of them.

Any suggestions on how to fix this? I was thinking of using a negative look ahead to not match with labels that starts with .functype, or CHECK-LABEL: emptyfn{{:|[}} as with .csect empty[PR].

[mustartt]

Verified that on the wasm32-wasip1 target passes with the following modification.

-// CHECK-LABEL: emptyfn
+// CHECK-LABEL: emptyfn{{:|\[}}

hjiang:rust-community$ ./x --stage 1 test tests/assembly/stack-protector --host= --target wasm32-wasip1 --force-rerun -- --logfile=run.log 
Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.09s
Building stage0 library artifacts (x86_64-unknown-linux-gnu)
    Finished `release` profile [optimized + debuginfo] target(s) in 0.05s
Building compiler artifacts (stage0 -> stage1, x86_64-unknown-linux-gnu)
    Finished `release` profile [optimized + debuginfo] target(s) in 0.33s
Creating a sysroot for stage1 compiler (use `rustup toolchain link 'name' build/host/stage1`)
Building stage1 library artifacts (x86_64-unknown-linux-gnu)
    Finished `release` profile [optimized + debuginfo] target(s) in 0.05s
Building stage0 tool compiletest (x86_64-unknown-linux-gnu)
    Finished `release` profile [optimized + debuginfo] target(s) in 0.20s
Building stage1 library artifacts (x86_64-unknown-linux-gnu -> wasm32-wasip1)
warning: dropping unsupported crate type `dylib` for target `wasm32-wasip1`

warning: `std` (lib) generated 1 warning
    Finished `release` profile [optimized + debuginfo] target(s) in 0.05s
Testing stage1 compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> wasm32-wasip1)

running 99 tests
iiiiiiiiii.............................................................................. 88/99
...........

test result: ok. 89 passed; 0 failed; 10 ignored; 0 measured; 435 filtered out; finished in 940.81ms

Build completed successfully in 0:00:03
hjiang:rust-community$ cat run.log | grep heuristics-effect.rs
ok [assembly] tests/assembly/stack-protector/stack-protector-heuristics-effect.rs#none
ok [assembly] tests/assembly/stack-protector/stack-protector-heuristics-effect.rs#basic
ok [assembly] tests/assembly/stack-protector/stack-protector-heuristics-effect.rs#strong
ok [assembly] tests/assembly/stack-protector/stack-protector-heuristics-effect.rs#missing
ok [assembly] tests/assembly/stack-protector/stack-protector-heuristics-effect.rs#all

@rustbot review

[Mark-Simulacrum]

@bors r+

[bors]

📌 Commit fb8c993 has been approved by Mark-Simulacrum

It is now in the queue for this repository.