Skip to content

Conversation

marcoieni
Copy link
Member

@marcoieni marcoieni commented Feb 5, 2025

In #136136 we moved free runners to ubuntu 24.
In this PR we move x86 large runners, too.
ARM runners will be moved in a separate PRs because they are a bit flaky and ubuntu 24 might have issues. This is based both on the failed try job of this PR and this zulip discussion.

try-job: dist-powerpc64le-linux
try-job: x86_64-gnu-debug
try-job: dist-arm-linux
try-job: x86_64-fuchsia
try-job: x86_64-gnu-distcheck
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt

@rustbot
Copy link
Collaborator

rustbot commented Feb 5, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 5, 2025
@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Feb 5, 2025

⌛ Trying commit 0a9525a with merge d8a248d...

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 5, 2025
…=<try>

ci: use ubuntu 24 for large runners

try-job: dist-powerpc64le-linux
try-job: x86_64-gnu-debug
try-job: dist-aarch64-linux
try-job: dist-arm-linux
try-job: x86_64-fuchsia
try-job: x86_64-gnu-distcheck
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
try-job: dist-aarch64-linux
@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Feb 5, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2025
@marcoieni
Copy link
Member Author

npm issue:

line 2: 147361 Segmentation fault (core dumped) npm ci

@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Feb 5, 2025

⌛ Trying commit 914c894 with merge 740a38b...

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 5, 2025
…=<try>

ci: use ubuntu 24 for large runners

try-job: dist-powerpc64le-linux
try-job: x86_64-gnu-debug
try-job: dist-aarch64-linux
try-job: dist-arm-linux
try-job: x86_64-fuchsia
try-job: x86_64-gnu-distcheck
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
try-job: dist-aarch64-linux
@bors
Copy link
Collaborator

bors commented Feb 5, 2025

☀️ Try build successful - checks-actions
Build commit: 740a38b (740a38b6c473126868b51bf85e51c34e0a0c6060)

@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Feb 5, 2025

⌛ Trying commit 914c894 with merge aa08090...

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 5, 2025
…=<try>

ci: use ubuntu 24 for large runners

try-job: dist-powerpc64le-linux
try-job: x86_64-gnu-debug
try-job: dist-aarch64-linux
try-job: dist-arm-linux
try-job: x86_64-fuchsia
try-job: x86_64-gnu-distcheck
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
try-job: dist-aarch64-linux
@bors
Copy link
Collaborator

bors commented Feb 5, 2025

☀️ Try build successful - checks-actions
Build commit: aa08090 (aa080901211644a624f6e537dca524190b9a64a2)

@marcoieni marcoieni changed the title ci: use ubuntu 24 for large runners ci: use ubuntu 24 for x86 large runners Feb 6, 2025
@marcoieni marcoieni force-pushed the ubuntu-24-large-runners branch from 914c894 to 0d9cb9c Compare February 6, 2025 14:13
@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Feb 6, 2025

⌛ Trying commit 0d9cb9c with merge 3e95a7a...

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 6, 2025
…=<try>

ci: use ubuntu 24 for x86 large runners

try-job: dist-powerpc64le-linux
try-job: x86_64-gnu-debug
try-job: dist-arm-linux
try-job: x86_64-fuchsia
try-job: x86_64-gnu-distcheck
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@bors bors mentioned this pull request Feb 6, 2025
@bors
Copy link
Collaborator

bors commented Feb 6, 2025

☀️ Try build successful - checks-actions
Build commit: 3e95a7a (3e95a7a1a4e9f48309ef91a7e4c1064ee969d49f)

@marcoieni
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 6, 2025
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Feb 9, 2025

📌 Commit 0d9cb9c has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2025
@bors
Copy link
Collaborator

bors commented Feb 11, 2025

⌛ Testing commit 0d9cb9c with merge 8c61cd4...

@bors
Copy link
Collaborator

bors commented Feb 11, 2025

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 8c61cd4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 11, 2025
@bors bors merged commit 8c61cd4 into rust-lang:master Feb 11, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 11, 2025
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8c61cd4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -5.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.7% [-5.7%, -5.7%] 1
All ❌✅ (primary) - - 0

Cycles

Results (primary -13.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.9% [0.9%, 0.9%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-14.2% [-18.7%, -10.3%] 13
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -13.1% [-18.7%, 0.9%] 14

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 787s -> 785.462s (-0.20%)
Artifact size: 348.27 MiB -> 348.30 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants