Skip to content

Add explicit_extern_abis Feature and Enforce Explicit ABIs #135340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2025
Merged

Add explicit_extern_abis Feature and Enforce Explicit ABIs #135340

merged 3 commits into from
Apr 17, 2025

Conversation

@obeis
Copy link
Contributor

@obeis obeis commented Jan 10, 2025 •
edited
Loading

The unstable explicit_extern_abis feature is introduced, requiring explicit ABIs in extern blocks. Hard errors will be enforced with this feature enabled in a future edition.

RFC rust-lang/rfcs#3722

Update #134986

@rustbot
Copy link
Collaborator

rustbot commented Jan 10, 2025

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 10, 2025

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

@traviscross traviscross added the F-explicit_extern_abis `#![feature(explicit_extern_abis)]` label Jan 10, 2025
ytmimi
ytmimi reviewed Jan 10, 2025
View reviewed changes
@traviscross
Copy link
Contributor

@rustbot labels +S-blocked
@rustbot author

We're still finalizing the timing and name of the next edition, and in any case, I think I'd like to see a separate PR for adding the various bits for the next edition that's separate from any edition item.

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2025
@traviscross traviscross mentioned this pull request Jan 10, 2025
Open
8 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@obeis obeis force-pushed the explicit-extern-abis branch from 938c721 to b327d2d Compare January 10, 2025 18:14
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@workingjubilee
Copy link
Member

I do not think we will accept the edition changes being folded into this PR, @obeis

@obeis obeis force-pushed the explicit-extern-abis branch from b327d2d to e25d0af Compare January 10, 2025 19:42
ytmimi
ytmimi reviewed Jan 10, 2025
View reviewed changes
@obeis obeis force-pushed the explicit-extern-abis branch from e25d0af to 20f28b1 Compare January 10, 2025 19:55
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@obeis obeis force-pushed the explicit-extern-abis branch 2 times, most recently from fe8b62b to bc8ed0e Compare January 10, 2025 20:30
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@obeis obeis force-pushed the explicit-extern-abis branch from bc8ed0e to e1db710 Compare January 11, 2025 15:05
@rustbot rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Jan 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2025

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@traviscross traviscross added S-waiting-on-team DEPRECATED: Use the team-based variants `S-waiting-on-t-lang`, `S-waiting-on-t-compiler`, ... and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 12, 2025
@Amanieu Amanieu removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jan 22, 2025
@obeis
Add explicit_extern_abis unstable feature
ee53c26 
also add `explicit-extern-abis` feature section to
the unstable book.
@obeis obeis force-pushed the explicit-extern-abis branch from 1159903 to 1a01c06 Compare April 15, 2025 11:33
traviscross
traviscross reviewed Apr 15, 2025
View reviewed changes
Copy link
Contributor

@traviscross traviscross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2025
@Nadrieril
Copy link
Member

I second @traviscross's review comments, and r=me once they are addressed.

@obeis obeis force-pushed the explicit-extern-abis branch from 1a01c06 to 7c51363 Compare April 16, 2025 19:16
@obeis obeis force-pushed the explicit-extern-abis branch from 7c51363 to d17c04e Compare April 16, 2025 19:44
@bors

This comment was marked as duplicate.

Sign in to view
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 16, 2025
@bors

This comment was marked as duplicate.

Sign in to view
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2025
@bors

This comment was marked as duplicate.

Sign in to view
@bors

This comment was marked as duplicate.

Sign in to view
@obeis
Copy link
Contributor Author

obeis commented Apr 16, 2025

@bors r=nadrieril rollup

@bors

This comment was marked as duplicate.

Sign in to view
@bors
Copy link
Collaborator

bors commented Apr 16, 2025

@obeis: 🔑 Insufficient privileges: not in try users

@traviscross
Copy link
Contributor

@bors r=traviscross,nadrieril rollup

@bors
Copy link
Collaborator

bors commented Apr 16, 2025

📌 Commit d17c04e has been approved by traviscross,nadrieril

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 16, 2025
Merged
@jieyouxu jieyouxu removed the A-run-make Area: port run-make Makefiles to rmake.rs label Apr 17, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2025
@bors
Auto merge of rust-lang#139940 - matthiaskrgr:rollup-rd4d3fn, r=matth…
15c4cce 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#135340 (Add `explicit_extern_abis` Feature and Enforce Explicit ABIs)
 - rust-lang#139440 (rustc_target: RISC-V: feature addition batch 2)
 - rust-lang#139667 (cfi: Remove #[no_sanitize(cfi)] for extern weak functions)
 - rust-lang#139828 (Don't require rigid alias's trait to hold)
 - rust-lang#139854 (Improve parse errors for stray lifetimes in type position)
 - rust-lang#139889 (Clean UI tests 3 of n)
 - rust-lang#139894 (Fix `opt-dist` CLI flag and make it work without LLD)
 - rust-lang#139900 (stepping into impls for normalization is unproductive)
 - rust-lang#139915 (replace some #[rustc_intrinsic] usage with use of the libcore declarations)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bb3e156 into rust-lang:master Apr 17, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 17, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2025
@rust-timer
Unrolled build for rust-lang#135340
6a96976 
Rollup merge of rust-lang#135340 - obeis:explicit-extern-abis, r=traviscross,nadrieril

Add `explicit_extern_abis` Feature and Enforce Explicit ABIs

The unstable `explicit_extern_abis` feature is introduced, requiring explicit ABIs in `extern` blocks. Hard errors will be enforced with this feature enabled in a future edition.

RFC rust-lang/rfcs#3722

Update rust-lang#134986
@obeis obeis deleted the explicit-extern-abis branch April 17, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@traviscross traviscross traviscross requested changes

@compiler-errors compiler-errors compiler-errors left review comments

@ytmimi ytmimi ytmimi left review comments

@Nadrieril Nadrieril Awaiting requested review from Nadrieril

Assignees

@Nadrieril Nadrieril

Labels

F-explicit_extern_abis `#![feature(explicit_extern_abis)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.