Skip to content

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Jan 5, 2025

Probably should also create a dev-guide reviewer pool for this repo 🤔

r? @Kobzol

@jieyouxu jieyouxu added A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-rustc-dev-guide Area: rustc-dev-guide labels Jan 5, 2025
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 5, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2025

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@BoxyUwU
Copy link
Member

BoxyUwU commented Jan 5, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 5, 2025

📌 Commit 5871867 has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2025
@BoxyUwU BoxyUwU assigned BoxyUwU and unassigned Kobzol Jan 5, 2025
@BoxyUwU
Copy link
Member

BoxyUwU commented Jan 5, 2025

For the reviewer pool stuff I somewhat feel like there's not much need- PRs that exclusively change dev guide should just go on the rustc-dev-guide repo and compiler changes that also happen to change the dev guide should just be reviewed by whoever is reviewing the compiler changes.

@jieyouxu
Copy link
Member Author

jieyouxu commented Jan 5, 2025

Yeah, that's what I thought as well

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 5, 2025
triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide`

Probably should also create a dev-guide reviewer pool for this repo 🤔

r? `@Kobzol`
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 5, 2025
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#135085 (add m68k-unknown-none-elf target)
 - rust-lang#135111 (Add doc aliases for `libm` and IEEE names)
 - rust-lang#135129 (triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide`)
 - rust-lang#135132 (dev guide ping group and set adhoc reviewers to compiler)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 6, 2025
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#135085 (add m68k-unknown-none-elf target)
 - rust-lang#135111 (Add doc aliases for `libm` and IEEE names)
 - rust-lang#135129 (triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide`)
 - rust-lang#135132 (dev guide ping group and set adhoc reviewers to compiler)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 6, 2025
Rollup of 4 pull requests

Successful merges:

 - rust-lang#135085 (add m68k-unknown-none-elf target)
 - rust-lang#135111 (Add doc aliases for `libm` and IEEE names)
 - rust-lang#135129 (triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide`)
 - rust-lang#135132 (dev guide ping group and set adhoc reviewers to compiler)

r? `@ghost`
`@rustbot` modify labels: rollup

try-job: dist-aarch64-apple
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 6, 2025
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#135111 (Add doc aliases for `libm` and IEEE names)
 - rust-lang#135129 (triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide`)
 - rust-lang#135132 (dev guide ping group and set adhoc reviewers to compiler)
 - rust-lang#135145 (Mention `unnameable_types` in `unreachable_pub` documentation.)
 - rust-lang#135147 (A few borrowck tweaks to improve 2024 edition migration lints)
 - rust-lang#135150 (move footnote to ordinary comment)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bb2c4ad into rust-lang:master Jan 6, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 6, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 6, 2025
Rollup merge of rust-lang#135129 - jieyouxu:tag-r-d-g, r=BoxyUwU

triagebot: label `src/doc/rustc-dev-guide` changes with `A-rustc-dev-guide`

Probably should also create a dev-guide reviewer pool for this repo 🤔

r? ``@Kobzol``
@jieyouxu jieyouxu deleted the tag-r-d-g branch January 6, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants