Account for C string literals and format_args in HiddenUnicodeCodepoints lint
#134956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
jieyouxu
added
A-lints
jieyouxu
approved these changes
Dec 31, 2024
| match mac { | ||
| Ok(mut fmt) if append_newline => { | ||
| fmt.0 = Symbol::intern(&format!("{}\n", fmt.0)); | ||
| fmt.symbol = Symbol::intern(&format!("{}\n", fmt.symbol)); |
There was a problem hiding this comment.
Remark: this is indeed easier to follow
|
Let's land both of them here in this PR. @bors r+ rollup |
bors
added
S-waiting-on-bors
jieyouxu
changed the title
format_args in HiddenUnicodeCodepoints lintformat_args in HiddenUnicodeCodepoints lint
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 31, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#134610 (Format `build.toml` consistently in platform support docs) - rust-lang#134918 (Windows: Enable issue 70093 link tests) - rust-lang#134953 (Fix doc for read&write unaligned in zst operation) - rust-lang#134956 (Account for C string literals and `format_args` in `HiddenUnicodeCodepoints` lint) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 31, 2024
Rollup merge of rust-lang#134956 - compiler-errors:format-args-hidden-chars, r=jieyouxu Account for C string literals and `format_args` in `HiddenUnicodeCodepoints` lint This is stacked on rust-lang#134955, and either that can land first or both of them can land together here. I split this out because this is a bit more involved of an impl. Fixes rust-lang#94945
github-actions bot
pushed a commit
to tautschnig/verify-rust-std
that referenced
this pull request
Mar 11, 2025
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#134610 (Format `build.toml` consistently in platform support docs) - rust-lang#134918 (Windows: Enable issue 70093 link tests) - rust-lang#134953 (Fix doc for read&write unaligned in zst operation) - rust-lang#134956 (Account for C string literals and `format_args` in `HiddenUnicodeCodepoints` lint) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is stacked on #134955, and either that can land first or both of them can land together here. I split this out because this is a bit more involved of an impl.
Fixes #94945