Skip to content

CI: split x86_64-msvc job #133632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

CI: split x86_64-msvc job #133632

wants to merge 2 commits into from

Conversation

marcoieni
Copy link
Member

@marcoieni marcoieni commented Nov 29, 2024 •
edited
Loading

r? @ghost

Split the x86_64-msvc job in two to move it to free runners and reduce the use of large runners in CI.

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 29, 2024
@marcoieni marcoieni changed the title CI: split x86_64-mingw job CI: split x86_64-msvc job Nov 29, 2024
marcoieni
marcoieni commented Nov 29, 2024
View reviewed changes
@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2024
@bors
Auto merge of rust-lang#133632 - MarcoIeni:split-x86_64-msvc, r=<try>
42d03ef 
CI: split x86_64-msvc job
@bors
Copy link
Collaborator

bors commented Nov 29, 2024

⌛ Trying commit 02bf397 with merge 42d03ef...

@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Collaborator

bors commented Nov 29, 2024

⌛ Trying commit f0d9ae4 with merge 09fe17c...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2024
@bors
Auto merge of rust-lang#133632 - MarcoIeni:split-x86_64-msvc, r=<try>
09fe17c 
CI: split x86_64-msvc job
@bors
Copy link
Collaborator

bors commented Nov 29, 2024

☀️ Try build successful - checks-actions
Build commit: 09fe17c (09fe17c13367761bb5cb434f5c396395a60583d3)

@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 2, 2024
@bors
Auto merge of rust-lang#133632 - MarcoIeni:split-x86_64-msvc, r=<try>
e716b8a 
CI: split x86_64-msvc job

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@bors
Copy link
Collaborator

bors commented Dec 2, 2024

⌛ Trying commit 70ab84d with merge e716b8a...

@bors bors mentioned this pull request Dec 2, 2024
Merged
@bors
Copy link
Collaborator

bors commented Dec 2, 2024

☀️ Try build successful - checks-actions
Build commit: e716b8a (e716b8a323240c5238cdf21b197bb0629aa79eed)

@marcoieni marcoieni marked this pull request as ready for review December 2, 2024 14:49
@marcoieni
Copy link
Member Author

looks good
image

@marcoieni
Copy link
Member Author

r? @Kobzol

@Kobzol
Copy link
Member

Kobzol commented Dec 3, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 3, 2024

📌 Commit 70ab84d has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2024
fmease added a commit to fmease/rust that referenced this pull request Dec 4, 2024
@fmease
Rollup merge of rust-lang#133632 - MarcoIeni:split-x86_64-msvc, r=Kobzol
d72aba0 
CI: split x86_64-msvc job

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@bors
Copy link
Collaborator

bors commented Dec 8, 2024

⌛ Testing commit 70ab84d with merge fe66833...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Dec 8, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 8, 2024
@Kobzol
Copy link
Member

Kobzol commented Dec 8, 2024

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 8, 2024
@bors
Auto merge of rust-lang#133632 - MarcoIeni:split-x86_64-msvc, r=Kobzol
03dea35 
CI: split x86_64-msvc job

try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@bors
Copy link
Collaborator

bors commented Dec 8, 2024

⌛ Testing commit 70ab84d with merge 03dea35...

@matthiaskrgr
Copy link
Member

I hope this will not double the number of spurious linker failures we are getting .. 😓

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Dec 8, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 8, 2024
@marcoieni
Copy link
Member Author

I hope this will not double the number of spurious linker failures we are getting .. 😓

True. If msvc has a lot of spurious errors, maybe we shouldn't merge this 🤔

@marcoieni
Copy link
Member Author

marcoieni commented Dec 9, 2024 •
edited
Loading

Actually, I saw all the workflows of the commits linked to this PR and none of them failed for the x86_64-msvc job.
Anyway, I'm fine holding this PR until we figure out https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/High.20failure.20rate.20on.20.60i686-mingw.60.20recently 👍

@jieyouxu
Copy link
Member

jieyouxu commented Dec 11, 2024 •
edited
Loading

True. If msvc has a lot of spurious errors, maybe we shouldn't merge this 🤔

I'm hoping (but not believing) that maybe somehow switching to a NTFS dev-drive might magically lower the spurious failure rate in #134056. Gonna try to see if that random thing thrown at the wall somehow sticks.

@jieyouxu
Copy link
Member

@bors r- (idk maybe someone sync'd?)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2024
@bors
Copy link
Collaborator

bors commented Jan 9, 2025

☔ The latest upstream changes (presumably #135286) made this pull request unmergeable. Please resolve the merge conflicts.

This was referenced Jan 14, 2025
Closed
Closed
@rustbot rustbot added the has-merge-commits PR has merge commits, merge with caution. label Jan 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 14, 2025

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust.git master
$ git push --force-with-lease

The following commits are merge commits:

@marcoieni marcoieni mentioned this pull request Jan 17, 2025
Merged
@marcoieni
Copy link
Member Author

closing because this job is too flaky for now to be splitted.

@marcoieni marcoieni closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Kobzol Kobzol

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@marcoieni @bors @Kobzol @jhpratt @rust-log-analyzer @matthiaskrgr @jieyouxu @rustbot