Skip to content

[beta] backports #133305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 22, 2024
Merged

[beta] backports #133305

merged 5 commits into from
Nov 22, 2024

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Nov 21, 2024

r? cuviper

compiler-errors and others added 5 commits November 21, 2024 09:26
@compiler-errors @cuviper
Enforce that raw lifetime identifiers must be valid raw identifiers
3c7babb 
(cherry picked from commit 9785c7c)
@jieyouxu @cuviper
Update cdb annotations for numeric-types with cdb 10.0.26100.2161
aa203c9 
(cherry picked from commit 1503279)
@jieyouxu @cuviper
Update cdb annotations for range-types.rs with cdb 10.0.26100.2161
a3021df 
(cherry picked from commit 94f3dcf)
@jieyouxu @cuviper
Update cdb annotations for unit-type.rs with cdb 10.0.26100.2161
088f06a 
(cherry picked from commit e70df09)
@jieyouxu @cuviper
Mark numeric-types.rs as 64-bit only for now
8435c75 
This is to unblock the tree, a proper fix will need to be investigated.
I think the debuginfo test suite supports revisions, however debugger
directives do not respect such revisions, which is problematic.

It's that 32-bit and 64-bit msvc of course have different integer widths
for `isize` and `usize`, meaning their underlying integer is different
and thus printed differently.

(cherry picked from commit dccb6c0)
@rustbot
Copy link
Collaborator

rustbot commented Nov 21, 2024

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 21, 2024
@cuviper
Copy link
Member Author

cuviper commented Nov 21, 2024

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Nov 21, 2024

📌 Commit 8435c75 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2024
@bors
Copy link
Collaborator

bors commented Nov 22, 2024

⌛ Testing commit 8435c75 with merge b35ad72...

@bors
Copy link
Collaborator

bors commented Nov 22, 2024

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing b35ad72 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 22, 2024
@bors bors merged commit b35ad72 into rust-lang:beta Nov 22, 2024
7 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Nov 22, 2024
@cuviper cuviper deleted the beta-next branch November 27, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
5 participants
@cuviper @rustbot @bors @compiler-errors @jieyouxu