Skip to content

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Nov 18, 2024

r? @ghost

tareknaser and others added 6 commits November 13, 2024 15:02
…rder_fields

Migrate `reorder_fields` Assist to Use `SyntaxFactory`
They were converted to LSP position using the current file's line index, which is obviously wrong.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 18, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 18, 2024

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@lnicola
Copy link
Member Author

lnicola commented Nov 18, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 18, 2024

📌 Commit 647749a has been approved by lnicola

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 18, 2024
Subtree update of `rust-analyzer`

r? ``@ghost``
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 18, 2024
Rollup of 4 pull requests

Successful merges:

 - rust-lang#132934 (Overhaul the `-l` option parser (for linking to native libs))
 - rust-lang#133142 (rename rustc_const_stable_intrinsic -> rustc_intrinsic_const_stable_indirect)
 - rust-lang#133145 (Document alternatives to `static mut`)
 - rust-lang#133158 (Subtree update of `rust-analyzer`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 18, 2024
Rollup of 4 pull requests

Successful merges:

 - rust-lang#132934 (Overhaul the `-l` option parser (for linking to native libs))
 - rust-lang#133142 (rename rustc_const_stable_intrinsic -> rustc_intrinsic_const_stable_indirect)
 - rust-lang#133145 (Document alternatives to `static mut`)
 - rust-lang#133158 (Subtree update of `rust-analyzer`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 194c76e into rust-lang:master Nov 18, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 18, 2024
Rollup merge of rust-lang#133158 - lnicola:sync-from-ra, r=lnicola

Subtree update of `rust-analyzer`

r? `@ghost`
@rustbot rustbot added this to the 1.84.0 milestone Nov 18, 2024
@lnicola lnicola deleted the sync-from-ra branch November 28, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants