Use `download-rustc=false` global default, `if-unchanged` for tools and library profiles, and make `rust.debug-assertions=true` inhibit downloading CI rustc #133068

jieyouxu · 2024-11-15T10:08:01Z

Use download-rustc = false as global default.
- Use download-rustc = 'if-unchanged' for tools and library profiles.
Make rust.debug-assertions = true inhibit downloading CI rustc because alt rustc builds do not yet have rustc debug assertions enabled.

cc discussions: https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Bootstrap.20breakage
compiler contributors poll: https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/.60download-rustc.20.3D.20'if-unchanged'.60.20for.20.60compiler.60.20profile.3F/near/481877253
library contributors poll: https://rust-lang.zulipchat.com/#narrow/channel/219381-t-libs/topic/.60download-rustc.20.3D.20.22if-unchanged.22.60.20default.20for.20libs.20profile.3F/near/482607011
cc https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/When.20is.20rustc.20built.20with.20debug.20assertions.3F

cc @marcoieni since you're working on improving CI job times, sorry, this will definitely regress some CI job times because we're probably lying to ourselves that CI rustc had debug assertions for some time 😅

cc @onur-ozkan for FYI, but since you're on vacation (sorry for the ping),

r? @Kobzol (I think you have a bit more context than other bootstrap reviewers?)

rustbot · 2024-11-15T10:08:11Z

This PR modifies src/bootstrap/defaults.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

This PR modifies config.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

jieyouxu · 2024-11-15T10:22:50Z

I think the motivation for download-rustc = 'if-unchanged' for library profile is to prepare for the staging redesign, not 100% certain.

jieyouxu · 2024-11-15T12:57:33Z

Waiting for libs contributors poll to determine if we want to set the library profile to use if-unchanged.
@rustbot blocked

jieyouxu · 2024-11-16T08:30:28Z

This seems mostly uncontroversial to use if-unchanged for library profile after improved detection logic in #131831.

@rustbot ready

jieyouxu · 2024-11-17T14:43:19Z

Maybe r? @clubby789 (Onur is on vacation and Jakub/Mark/Albert is busy AFAIK)

src/bootstrap/src/core/config/config.rs

clubby789

Seems reasonable, r=me with typo fix

EDIT: There's also a leftover 'for' a couple of lines above

src/bootstrap/src/core/config/config.rs

jieyouxu · 2024-11-17T15:25:34Z

Only change is typo fix (diff).

jieyouxu · 2024-11-23T16:00:08Z

Review comments addressed, this has no other significant changes since last review, so
@bors r=@clubby789 rollup=never (significant bootstrap/CI changes)

bors · 2024-11-23T16:00:11Z

📌 Commit f7f8ad9 has been approved by clubby789

It is now in the queue for this repository.

jieyouxu · 2024-11-23T16:01:10Z

Actually I should wait for PR CI.
@bors r-

jieyouxu · 2024-11-24T08:16:17Z

@bors r=@clubby789 rollup=never

bors · 2024-11-24T08:16:20Z

📌 Commit f7f8ad9 has been approved by clubby789

It is now in the queue for this repository.

…-for-tools, r=clubby789 Use `download-rustc=false` global default, `if-unchanged` for tools and library profiles, and make `rust.debug-assertions=true` inhibit downloading CI rustc - Use `download-rustc = false` as global default. - Use `download-rustc = 'if-unchanged'` for tools and library profiles. - Make `rust.debug-assertions = true` inhibit downloading CI rustc because alt rustc builds do not yet have rustc debug assertions enabled. Fixes rust-lang#133132. cc discussions: https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Bootstrap.20breakage compiler contributors poll: https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/.60download-rustc.20.3D.20'if-unchanged'.60.20for.20.60compiler.60.20profile.3F/near/481877253 library contributors poll: https://rust-lang.zulipchat.com/#narrow/channel/219381-t-libs/topic/.60download-rustc.20.3D.20.22if-unchanged.22.60.20default.20for.20libs.20profile.3F/near/482607011 cc https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/When.20is.20rustc.20built.20with.20debug.20assertions.3F cc `@MarcoIeni` since you're working on improving CI job times, sorry, this will definitely regress some CI job times because we're probably lying to ourselves that CI rustc had debug assertions for some time 😅 cc `@onur-ozkan` for FYI, but since you're on vacation (sorry for the ping), r? `@Kobzol` (I *think* you have a bit more context than other bootstrap reviewers?)

bors · 2024-11-24T13:16:34Z

⌛ Testing commit f7f8ad9 with merge c16c0f6...

rust-log-analyzer · 2024-11-24T15:07:03Z

The job x86_64-gnu-aux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2024-11-24T15:07:36Z

💔 Test failed - checks-actions

jieyouxu · 2024-11-24T15:11:36Z

@bors retry (spurious miri failure)

bors · 2024-11-24T16:28:58Z

⌛ Testing commit f7f8ad9 with merge 481b5fa...

bors · 2024-11-24T19:13:25Z

☀️ Test successful - checks-actions
Approved by: clubby789
Pushing 481b5fa to master...

rust-timer · 2024-11-24T20:32:07Z

Finished benchmarking commit (481b5fa): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.2%	[1.2%, 1.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 797.067s -> 798.184s (0.14%)
Artifact size: 336.23 MiB -> 336.25 MiB (0.01%)

rustbot assigned Kobzol Nov 15, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 15, 2024

rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2024

jieyouxu force-pushed the download-rustc-default-only-for-tools branch from 2e477ae to 92c6f0f Compare November 15, 2024 14:04

jieyouxu changed the title ~~Revert global default for download-rustc to false and only use if-unchanged for tools profile default~~ Revert global default for download-rustc to false and only use if-unchanged for tools and library profile defaults Nov 15, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Nov 16, 2024

jieyouxu force-pushed the download-rustc-default-only-for-tools branch from 92c6f0f to 727183f Compare November 17, 2024 14:38

jieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2024

jieyouxu mentioned this pull request Nov 17, 2024

add some debug-assertion crash tests #132789

Merged

rustbot assigned clubby789 and unassigned Kobzol Nov 17, 2024

jieyouxu added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 17, 2024

jieyouxu force-pushed the download-rustc-default-only-for-tools branch from 727183f to b05d37e Compare November 17, 2024 14:52

jieyouxu commented Nov 17, 2024

View reviewed changes

src/bootstrap/src/core/config/config.rs Outdated Show resolved Hide resolved

jieyouxu force-pushed the download-rustc-default-only-for-tools branch from b05d37e to 9f10635 Compare November 17, 2024 14:54

clubby789 approved these changes Nov 17, 2024

View reviewed changes

src/bootstrap/src/core/config/config.rs Outdated Show resolved Hide resolved

jieyouxu force-pushed the download-rustc-default-only-for-tools branch from 9f10635 to 1c4940e Compare November 17, 2024 15:24

This comment has been minimized.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 23, 2024

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 23, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 24, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 24, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2024

jieyouxu mentioned this pull request Nov 24, 2024

Spurious miri library rwlock test failure? #133421

Closed

jieyouxu added the CI-ABA-ptr-provenance-lockless-queue-fail CI spurious failure: related to #121950 label Nov 24, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 24, 2024

bors merged commit 481b5fa into rust-lang:master Nov 24, 2024
7 checks passed

rustbot added this to the 1.85.0 milestone Nov 24, 2024

jieyouxu deleted the download-rustc-default-only-for-tools branch November 24, 2024 19:16

jieyouxu mentioned this pull request Dec 5, 2024

Rustc 1.84 beta3 can't build from tarball: bootstrap try to find git commit on non git directory #133860

Closed

Use download-rustc=false global default, if-unchanged for tools and library profiles, and make rust.debug-assertions=true inhibit downloading CI rustc #133068

Use download-rustc=false global default, if-unchanged for tools and library profiles, and make rust.debug-assertions=true inhibit downloading CI rustc #133068

Uh oh!

Conversation

jieyouxu commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Nov 15, 2024

Uh oh!

jieyouxu commented Nov 15, 2024

Uh oh!

jieyouxu commented Nov 15, 2024

Uh oh!

jieyouxu commented Nov 16, 2024

Uh oh!

jieyouxu commented Nov 17, 2024

Uh oh!

Uh oh!

clubby789 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jieyouxu commented Nov 17, 2024

Uh oh!

This comment has been minimized.

jieyouxu commented Nov 23, 2024

Uh oh!

bors commented Nov 23, 2024

Uh oh!

jieyouxu commented Nov 23, 2024

Uh oh!

jieyouxu commented Nov 24, 2024

Uh oh!

bors commented Nov 24, 2024

Uh oh!

bors commented Nov 24, 2024

Uh oh!

rust-log-analyzer commented Nov 24, 2024

Uh oh!

bors commented Nov 24, 2024

Uh oh!

jieyouxu commented Nov 24, 2024

Uh oh!

bors commented Nov 24, 2024

Uh oh!

bors commented Nov 24, 2024

Uh oh!

Uh oh!

rust-timer commented Nov 24, 2024

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Use `download-rustc=false` global default, `if-unchanged` for tools and library profiles, and make `rust.debug-assertions=true` inhibit downloading CI rustc #133068

Use `download-rustc=false` global default, `if-unchanged` for tools and library profiles, and make `rust.debug-assertions=true` inhibit downloading CI rustc #133068

jieyouxu commented Nov 15, 2024 •

edited

Loading

clubby789 left a comment •

edited

Loading