Skip to content

force-recompile library changes on download-rustc="if-unchanged" #132267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2024
Merged

force-recompile library changes on download-rustc="if-unchanged" #132267

merged 2 commits into from
Oct 31, 2024

Conversation

onur-ozkan
Copy link
Contributor

This makes the download-rustc="if-unchanged" option more functional and useful for library developers.

Implements the second item from this tracking issue.

@onur-ozkan
force-recompile library changes on download-rustc="if-unchanged"
5cf6b8b 
This makes download-rustc="if-unchanged" more functional and useful
for library developers.

Signed-off-by: onur-ozkan <[email protected]>
@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 28, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2024

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@onur-ozkan
Copy link
Contributor Author

There are already some PRs awaiting reviews from Mark.

r? bootstrap

@rustbot rustbot assigned Kobzol and unassigned Mark-Simulacrum Oct 28, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2024

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

This PR modifies config.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@onur-ozkan
Copy link
Contributor Author

I got some ideas to make this better. I will work on them later.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2024
@onur-ozkan
Copy link
Contributor Author

I got some ideas to make this better. I will work on them later.

@rustbot author

I was planning to change the staging logic for CI rustc, then I realized it's too much for this particular task. For now, this PR should meet the intended purpose (I believe).

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 29, 2024
@Kobzol
Copy link
Member

Kobzol commented Oct 30, 2024

Was a bit of a head-spin (if if_unchanged always triggers me :D), but it makes sense to me.

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 30, 2024

📌 Commit 7e064e7 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 30, 2024
@GuillaumeGomez
Rollup merge of rust-lang#132267 - onur-ozkan:rustc-if-unchanged-forc…
c66a20e 
…e-library, r=Kobzol

force-recompile library changes on download-rustc="if-unchanged"

This makes the download-rustc="if-unchanged" option more functional and useful for library developers.

Implements the second item from [this tracking issue](rust-lang#131744).
@GuillaumeGomez GuillaumeGomez mentioned this pull request Oct 30, 2024
Closed
@workingjubilee workingjubilee mentioned this pull request Oct 30, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 30, 2024
@bors
Auto merge of rust-lang#132371 - workingjubilee:rollup-aqd86tm, r=wor…
4add5e4 
…kingjubilee

Rollup of 5 pull requests

Successful merges:

 - rust-lang#129383 (Remap impl-trait lifetimes on HIR instead of AST lowering)
 - rust-lang#132210 (rustdoc: make doctest span tweak a 2024 edition change)
 - rust-lang#132246 (Rename `rustc_abi::Abi` to `BackendRepr`)
 - rust-lang#132267 (force-recompile library changes on download-rustc="if-unchanged")
 - rust-lang#132344 (Merge `HostPolarity` and `BoundConstness`)

Failed merges:

 - rust-lang#132347 (Remove `ValueAnalysis` and `ValueAnalysisWrapper`.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f90abe7 into rust-lang:master Oct 31, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 31, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 31, 2024
@rust-timer
Unrolled build for rust-lang#132267
608803f 
Rollup merge of rust-lang#132267 - onur-ozkan:rustc-if-unchanged-force-library, r=Kobzol

force-recompile library changes on download-rustc="if-unchanged"

This makes the download-rustc="if-unchanged" option more functional and useful for library developers.

Implements the second item from [this tracking issue](rust-lang#131744).
@onur-ozkan onur-ozkan deleted the rustc-if-unchanged-force-library branch October 31, 2024 02:22
@onur-ozkan onur-ozkan mentioned this pull request Nov 2, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 2, 2024
@matthiaskrgr
Rollup merge of rust-lang#132494 - onur-ozkan:library-profile-default…
bfcd9ec 
…, r=jieyouxu

make `download-rustc="if-unchanged"` default for library profile

Since `download-rustc` is tested on CI and rust-lang#132267 makes it effective for library development, we can now make it default for the library profile.

Implements the 3rd item from [this tracking issue](rust-lang#131744).
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 2, 2024
@rust-timer
Unrolled build for rust-lang#132494
f997188 
Rollup merge of rust-lang#132494 - onur-ozkan:library-profile-default, r=jieyouxu

make `download-rustc="if-unchanged"` default for library profile

Since `download-rustc` is tested on CI and rust-lang#132267 makes it effective for library development, we can now make it default for the library profile.

Implements the 3rd item from [this tracking issue](rust-lang#131744).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Kobzol Kobzol

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
5 participants
@onur-ozkan @rustbot @Kobzol @bors @Mark-Simulacrum