Skip to content

Conversation

onur-ozkan
Copy link
Contributor

This provides very useful logs especially when debugging build cache-related stuff.

@rustbot
Copy link
Collaborator

rustbot commented Sep 30, 2024

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 30, 2024
@onur-ozkan onur-ozkan force-pushed the cargo-compiler-fingerprint branch from 7fb232a to 874d55c Compare September 30, 2024 10:14
@Kobzol
Copy link
Member

Kobzol commented Sep 30, 2024

Oh this is gonna be very verbose 😆 But I agree that it's indeed quite useful. You can r=me once CI is green.

@onur-ozkan
Copy link
Contributor Author

Oh this is gonna be very verbose 😆 But I agree that it's indeed quite useful. You can r=me once CI is green.

We could enable this on the verbosity level 2, but then it will be super hard to find them.. We could create a config option for it, but I am not sure if it's worth it.

@Kobzol
Copy link
Member

Kobzol commented Sep 30, 2024

Let's just keep it as it is, the verbose mode is currently only used for debugging bootstrap anyway, I suppose.

@onur-ozkan
Copy link
Contributor Author

@bors r=Kobzol

@bors
Copy link
Collaborator

bors commented Sep 30, 2024

📌 Commit 874d55c has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 30, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#131023 (Copy correct path to clipboard for modules/keywords/primitives)
 - rust-lang#131035 (Preserve brackets around if-lets and skip while-lets)
 - rust-lang#131038 (Fix `adt_const_params` leaking `{type error}` in error msg)
 - rust-lang#131053 (Improve `--print=check-cfg` documentation)
 - rust-lang#131056 (enable compiler fingerprint logs in verbose mode)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 30, 2024
Rollup merge of rust-lang#131056 - onur-ozkan:cargo-compiler-fingerprint, r=Kobzol

enable compiler fingerprint logs in verbose mode

This provides very useful logs especially when debugging build cache-related stuff.
@bors bors merged commit fd67755 into rust-lang:master Sep 30, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 30, 2024
@onur-ozkan onur-ozkan deleted the cargo-compiler-fingerprint branch October 1, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants