Skip to content

Conversation

veera-sivarajan
Copy link
Contributor

This PR moves the test headers to the top in a couple of test files to maintain consistent style.

Based on this comment: #130665 (comment)

@rustbot
Copy link
Collaborator

rustbot commented Sep 23, 2024

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 23, 2024
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 23, 2024

📌 Commit ca450e1 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2024
@rust-log-analyzer

This comment has been minimized.

@compiler-errors
Copy link
Member

@bors r-

test needs blessed

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 23, 2024
@veera-sivarajan
Copy link
Contributor Author

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Sep 26, 2024

@veera-sivarajan: 🔑 Insufficient privileges: Not in reviewers

@jieyouxu
Copy link
Member

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Sep 27, 2024

📌 Commit 8cf861d has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 27, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#130718 (Cleanup some known-bug issues)
 - rust-lang#130730 (Reorganize Test Headers)
 - rust-lang#130826 (Compiler: Rename "object safe" to "dyn compatible")
 - rust-lang#130915 (fix typo in triagebot.toml)
 - rust-lang#130926 (Update cc to 1.1.22 in library/)
 - rust-lang#130932 (etc: Add sample rust-analyzer configs for eglot & helix)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#130718 (Cleanup some known-bug issues)
 - rust-lang#130730 (Reorganize Test Headers)
 - rust-lang#130826 (Compiler: Rename "object safe" to "dyn compatible")
 - rust-lang#130915 (fix typo in triagebot.toml)
 - rust-lang#130926 (Update cc to 1.1.22 in library/)
 - rust-lang#130932 (etc: Add sample rust-analyzer configs for eglot & helix)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#130718 (Cleanup some known-bug issues)
 - rust-lang#130730 (Reorganize Test Headers)
 - rust-lang#130826 (Compiler: Rename "object safe" to "dyn compatible")
 - rust-lang#130915 (fix typo in triagebot.toml)
 - rust-lang#130926 (Update cc to 1.1.22 in library/)
 - rust-lang#130932 (etc: Add sample rust-analyzer configs for eglot & helix)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ae43f27 into rust-lang:master Sep 28, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 28, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 28, 2024
Rollup merge of rust-lang#130730 - veera-sivarajan:clean-test-headers, r=compiler-errors

Reorganize Test Headers

This PR moves the test headers to the top in a couple of test files to maintain consistent style.

Based on this comment: rust-lang#130665 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants