Skip to content

Conversation

Dajamante
Copy link
Contributor

@rustbot
Copy link
Collaborator

rustbot commented Jul 29, 2024

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 29, 2024
@pietroalbini
Copy link
Member

r? @pietroalbini
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 29, 2024

📌 Commit 28fc4a1 has been approved by pietroalbini

It is now in the queue for this repository.

@rustbot rustbot assigned pietroalbini and unassigned lcnr Jul 29, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2024
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-17 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
------
 > importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:3aacb9c90579defe09351ac5e8ee504359f8054da6326ff19038f1b7c90e3cb2aafe33685c6d9b76ee8d2ccbd187ca80c46ab5380485abdd8c0ce7d69cd8d8fd:
------
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-17]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-17', '--enable-llvm-link-shared', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-17/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.thin-lto-import-instr-limit := 10
configure: change-id            := 99999999
---
---- [ui] tests/ui/backtrace/synchronized-panic-handler.rs stdout ----
diff of run.stderr:

- thread '<unnamed>' panicked at $DIR/synchronized-panic-handler.rs:10:5:
+ thread '<unnamed>' panicked at $DIR/synchronized-panic-handler.rs:11:5:
2 oops oh no woe is me
- thread '<unnamed>' panicked at $DIR/synchronized-panic-handler.rs:10:5:
+ thread '<unnamed>' panicked at $DIR/synchronized-panic-handler.rs:11:5:
+ thread '<unnamed>' panicked at $DIR/synchronized-panic-handler.rs:11:5:
5 oops oh no woe is me


The actual run.stderr differed from the expected run.stderr.
Actual run.stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/backtrace/synchronized-panic-handler/synchronized-panic-handler.run.stderr
Actual run.stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/backtrace/synchronized-panic-handler/synchronized-panic-handler.run.stderr

error: 1 errors occurred comparing run output.
status: exit status: 0
command: cd "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/backtrace/synchronized-panic-handler" && RUST_BACKTRACE="0" RUST_TEST_THREADS="16" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/backtrace/synchronized-panic-handler/a"
stdout: none
--- stderr -------------------------------
thread '<unnamed>' panicked at /checkout/tests/ui/backtrace/synchronized-panic-handler.rs:11:5:
oops oh no woe is me
thread '<unnamed>' panicked at /checkout/tests/ui/backtrace/synchronized-panic-handler.rs:11:5:
thread '<unnamed>' panicked at /checkout/tests/ui/backtrace/synchronized-panic-handler.rs:11:5:
oops oh no woe is me



failures:

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 29, 2024
the output in `stderr` expects `panic-unwind`

r​? `@pietroalbini`
@pietroalbini
Copy link
Member

@Dajamante you will need to bless the tests.

@pietroalbini
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 29, 2024
@Dajamante Dajamante closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants