Skip to content

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Jun 8, 2024

Fixes: #126164

This still prints an error if any occurs.

@rustbot
Copy link
Collaborator

rustbot commented Jun 8, 2024

Failed to set assignee to tgross35: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 8, 2024
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can’t r but this looks good to me!

@fmease
Copy link
Member

fmease commented Jun 9, 2024

r? bootstrap

@albertlarsan68
Copy link
Member

@bors r=tgross35 rollup

@bors
Copy link
Collaborator

bors commented Jun 9, 2024

📌 Commit 1ade7cb has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 9, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#126137 (tests: Add ui/higher-ranked/trait-bounds/normalize-generic-arg.rs)
 - rust-lang#126146 (std::unix::process adding few specific freebsd signals to be able to id.)
 - rust-lang#126155 (Remove empty test suite `tests/run-make-fulldeps`)
 - rust-lang#126168 (std::unix::os current_exe implementation simplification for haiku.)
 - rust-lang#126175 (Use --quiet flag when installing pip dependencies)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8875fd1 into rust-lang:master Jun 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 9, 2024
Rollup merge of rust-lang#126175 - Kobzol:tidy-install-pip-quiet, r=tgross35

Use --quiet flag when installing pip dependencies

Fixes: rust-lang#126164

This still prints an error if any occurs.
@rustbot rustbot added this to the 1.81.0 milestone Jun 9, 2024
@Kobzol Kobzol deleted the tidy-install-pip-quiet branch June 9, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: tidy errors are hidden by verbose Python dependency resolution logging
7 participants