Skip to content

Uplift {Closure,Coroutine,CoroutineClosure}Args and friends to rustc_type_ir #125775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 1, 2024
Merged

Uplift {Closure,Coroutine,CoroutineClosure}Args and friends to rustc_type_ir #125775

merged 2 commits into from
Jun 1, 2024

Conversation

compiler-errors
Copy link
Member

Part of converting the new solver's structural_traits.rs to be interner-agnostic.

I decided against aliasing ClosureArgs<TyCtxt<'tcx>> to ClosureArgs<'tcx> because it seemed so rare. I could do so if desired, though.

r? lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels May 30, 2024
@rustbot
Copy link
Collaborator

rustbot commented May 30, 2024

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

changes to the core type system

cc @compiler-errors, @lcnr

@rust-log-analyzer

This comment has been minimized.

Sign in to view
lcnr
lcnr reviewed May 30, 2024
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with or without nit

compiler/rustc_type_ir/src/ty_kind/closure.rs
}
}

struct FoldEscapingRegions<I: Interner> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

existing: i feel like this folder should have a comment

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented May 31, 2024

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member Author

Sorry for the CI failures. Tried to be smart with an assertion, but it was misguided.

@bors r=lcnr

@bors
Copy link
Collaborator

bors commented Jun 1, 2024

📌 Commit 5afdda1 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 1, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 1, 2024
@matthiaskrgr
Rollup merge of rust-lang#125775 - compiler-errors:uplift-closure-arg…
dd4de05 
…s, r=lcnr

Uplift `{Closure,Coroutine,CoroutineClosure}Args` and friends to `rustc_type_ir`

Part of converting the new solver's `structural_traits.rs` to be interner-agnostic.

I decided against aliasing `ClosureArgs<TyCtxt<'tcx>>` to `ClosureArgs<'tcx>` because it seemed so rare. I could do so if desired, though.

r? lcnr
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 1, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 1, 2024
@matthiaskrgr
Rollup merge of rust-lang#125775 - compiler-errors:uplift-closure-arg…
cd15ad9 
…s, r=lcnr

Uplift `{Closure,Coroutine,CoroutineClosure}Args` and friends to `rustc_type_ir`

Part of converting the new solver's `structural_traits.rs` to be interner-agnostic.

I decided against aliasing `ClosureArgs<TyCtxt<'tcx>>` to `ClosureArgs<'tcx>` because it seemed so rare. I could do so if desired, though.

r? lcnr
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 1, 2024
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member Author

intra doc links :(

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 1, 2024
@compiler-errors
Copy link
Member Author

@bors r=lcnr

@bors
Copy link
Collaborator

bors commented Jun 1, 2024

📌 Commit 333458c has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 1, 2024
@bors
Copy link
Collaborator

bors commented Jun 1, 2024

⌛ Testing commit 333458c with merge 0038c02...

@bors
Copy link
Collaborator

bors commented Jun 1, 2024

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 0038c02 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 1, 2024
@bors bors merged commit 0038c02 into rust-lang:master Jun 1, 2024
@rustbot rustbot added this to the 1.80.0 milestone Jun 1, 2024
@bors bors mentioned this pull request Jun 1, 2024
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0038c02): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.2% [3.2%, 3.2%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.2% [3.2%, 3.2%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.545s -> 667.702s (-0.13%)
Artifact size: 318.79 MiB -> 318.95 MiB (0.05%)

flip1995 pushed a commit to flip1995/rust that referenced this pull request Jun 13, 2024
@bors
Auto merge of rust-lang#125775 - compiler-errors:uplift-closure-args,…
ab45660 
… r=lcnr

Uplift `{Closure,Coroutine,CoroutineClosure}Args` and friends to `rustc_type_ir`

Part of converting the new solver's `structural_traits.rs` to be interner-agnostic.

I decided against aliasing `ClosureArgs<TyCtxt<'tcx>>` to `ClosureArgs<'tcx>` because it seemed so rare. I could do so if desired, though.

r? lcnr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.
6 participants
@compiler-errors @rustbot @rust-log-analyzer @bors @rust-timer @lcnr