Skip to content

Conversation

spastorino
Copy link
Member

@spastorino spastorino commented May 11, 2024

r? @compiler-errors

Related to #123929

@rustbot
Copy link
Collaborator

rustbot commented May 11, 2024

HIR ty lowering was modified

cc @fmease

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 11, 2024
@rust-log-analyzer

This comment has been minimized.

Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix clippy and rustfmt, otherwise looks fine. I will review again when it's fixed.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2024
@spastorino spastorino force-pushed the generics-is-empty branch from 633bede to 76eeee1 Compare May 12, 2024 21:11
@spastorino
Copy link
Member Author

Please fix clippy and rustfmt, otherwise looks fine. I will review again when it's fixed.

Not sure what do you mean by fix clippy. About rustfmt is fixed, didn't realize rustfmt was using ast::Generics.

@spastorino
Copy link
Member Author

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 13, 2024
@bors
Copy link
Collaborator

bors commented May 19, 2024

☔ The latest upstream changes (presumably #125257) made this pull request unmergeable. Please resolve the merge conflicts.

@spastorino spastorino force-pushed the generics-is-empty branch from 76eeee1 to 4501ae8 Compare May 19, 2024 14:45
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented May 19, 2024

📌 Commit 4501ae8 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2024
@bors
Copy link
Collaborator

bors commented May 19, 2024

⌛ Testing commit 4501ae8 with merge 1d1283e...

@bors
Copy link
Collaborator

bors commented May 19, 2024

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 1d1283e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 19, 2024
@bors bors merged commit 1d1283e into rust-lang:master May 19, 2024
@rustbot rustbot added this to the 1.80.0 milestone May 19, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1d1283e): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.3% [-0.3%, -0.3%] 1
Improvements ✅
(secondary)
-1.4% [-1.4%, -1.4%] 1
All ❌✅ (primary) -0.3% [-0.3%, -0.3%] 1

Max RSS (memory usage)

Results (primary -2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.0% [-2.0%, -2.0%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.0% [-2.0%, -2.0%] 1

Cycles

Results (secondary -3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.0% [-5.4%, -1.5%] 15
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.813s -> 668.514s (-0.19%)
Artifact size: 316.18 MiB -> 316.20 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants