Skip to content

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels May 6, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=3

@bors
Copy link
Collaborator

bors commented May 6, 2024

📌 Commit 78ee4ce has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2024
@bors
Copy link
Collaborator

bors commented May 6, 2024

⌛ Testing commit 78ee4ce with merge d287f3e...

@bors
Copy link
Collaborator

bors commented May 6, 2024

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing d287f3e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 6, 2024
@bors bors merged commit d287f3e into rust-lang:master May 6, 2024
@rustbot rustbot added this to the 1.80.0 milestone May 6, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#124742 Add rustfmt cfg to well known cfgs list 7890805d7ef58592ceef700f9bd4cf6073d1b461 (link)
#124765 [rustdoc] Fix bad color for setting cog in ayu theme af7b8eb6c76ad53b2204208ac3bdc6dfdd45502f (link)
#124768 [resubmission] Meta: Enable the brand new triagebot transfe… d9495199712b502d6d535a39fa3dd980e7491351 (link)

previous master: 96f1da8268

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d287f3e): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.3% [0.2%, 0.4%] 5
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.3% [0.2%, 0.4%] 5

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.9% [3.8%, 3.9%] 2
Improvements ✅
(primary)
-2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.2% [-2.2%, -2.2%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 675.971s -> 674.088s (-0.28%)
Artifact size: 315.93 MiB -> 315.91 MiB (-0.01%)

@rustbot rustbot added the perf-regression Performance regression. label May 6, 2024
@lqd
Copy link
Member

lqd commented May 6, 2024

Likely #124742

@pnkfelix
Copy link
Contributor

pnkfelix commented May 7, 2024

Visiting for perf-triage

  • all regressions were to syn, to various incr-unchanged and incr-patched:println scenarios.
  • current hypothesis is that this is due to PR Add rustfmt cfg to well known cfgs list #124742, which adds rustfmt to the well known cfgs list.
  • that hypothesis implies that this is a (mostly-)false alarm, much like Update cargo #124684.
  • marking as triaged

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label May 7, 2024
@matthiaskrgr matthiaskrgr deleted the rollup-e9pg3v4 branch September 1, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants