Rollup of 4 pull requests #124633
Closed
Rollup of 4 pull requests #124633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"is greater or equal to". Beside common sense.
library/backtrace also declares a feature called `gimli-symbolize` which appear used, but the feature in std with the same name is unused, so remove it.
this directive prevents compiletest from adding any implicit and automatic --check-cfg arguments
…youxu
Enable `--check-cfg` by default in UI tests
This PR enables-by-default `--check-cfg` in UI tests, now that it has become stable.
To do so this PR does 2 main things:
- it introduce the `no-auto-check-cfg` directive to `compiletest`, to prevent any `--check-cfg` args (only to be used for `--check-cfg` tests)
- it updates the _remaining_[^1] UI tests by either:
- allowing the lint when neither expecting the lint nor giving the check-cfg args make sense
- give the appropriate check-cfg args
- or expect the lint, when it useful
[^1]: some preparation work was done in rust-lang#123577 rust-lang#123702
I highly recommend reviewing this PR commit-by-commit.
r? `@jieyouxu`
io safety: update Unix explanation to use `Arc` Fixes rust-lang#124384 Cc ``@jsgf``
…s, r=Amanieu String.truncate comment microfix (greater or equal) String.truncate calls Vec.truncate, in turn, and that states "is greater or equal to". Beside common sense.
…kingjubilee library/std: Remove unused `gimli-symbolize` feature library/backtrace also declares a feature called `gimli-symbolize` which appear used, but the feature in std with the same name is unused, so remove it.
rustbot
added
A-testsuite
|
@bors r+ rollup=never p=6 |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#124345 (Enable `--check-cfg` by default in UI tests) - rust-lang#124412 (io safety: update Unix explanation to use `Arc`) - rust-lang#124441 (String.truncate comment microfix (greater or equal)) - rust-lang#124604 (library/std: Remove unused `gimli-symbolize` feature) Failed merges: - rust-lang#124607 (`rustc_expand` cleanups) - rust-lang#124613 (Allow fmt to run on rmake.rs test files) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#124345 (Enable `--check-cfg` by default in UI tests) - rust-lang#124412 (io safety: update Unix explanation to use `Arc`) - rust-lang#124441 (String.truncate comment microfix (greater or equal)) - rust-lang#124604 (library/std: Remove unused `gimli-symbolize` feature) Failed merges: - rust-lang#124607 (`rustc_expand` cleanups) - rust-lang#124613 (Allow fmt to run on rmake.rs test files) r? `@ghost` `@rustbot` modify labels: rollup
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
removed
the
S-waiting-on-bors
bors
added
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
--check-cfgby default in UI tests #124345 (Enable--check-cfgby default in UI tests)Arc#124412 (io safety: update Unix explanation to useArc)gimli-symbolizefeature #124604 (library/std: Remove unusedgimli-symbolizefeature)Failed merges:
rustc_expandcleanups #124607 (rustc_expandcleanups)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup