parser: suggest quotes only for ident attribute values

compiler/rustc_parse/src/parser/attr.rs

@@ -412,7 +412,10 @@ impl<'a> Parser<'a> {
         // Check for unquoted idents in meta items, e.g.: #[cfg(key = foo)]
         // `from_expansion()` ensures we don't suggest for cases such as
         // `#[cfg(feature = $expr)]` in macros
-        if self.prev_token == token::Eq && !self.token.span.from_expansion() {
+        if self.token.is_ident()
+            && self.prev_token == token::Eq
+            && !self.token.span.from_expansion()
+        {
             let before = self.token.span.shrink_to_lo();
             while matches!(self.token.kind, token::Ident(..)) {
                 self.bump();

tests/ui/attributes/suggest_quoting_values_only_for_idents.rs

@@ -0,0 +1,7 @@
+// Ensures to suggest quoting attribute values only when they are identifiers.
+
+#[doc(alias = "val")]
+#[doc(alias = val)] //~ ERROR expected unsuffixed literal, found `val`
+#[doc(alias = ["va", "al"])] //~ ERROR expected unsuffixed literal or identifier, found `[`
+#[doc(alias = &["va", "al"])] //~ ERROR expected unsuffixed literal or identifier, found `&`
+fn main() {}

tests/ui/attributes/suggest_quoting_values_only_for_idents.stderr

@@ -0,0 +1,25 @@
+error: expected unsuffixed literal, found `val`
+  --> $DIR/suggest_quoting_values_only_for_idents.rs:4:15
+   |
+LL | #[doc(alias = val)]
+   |               ^^^
+   |
+help: surround the identifier with quotation marks to parse it as a string
+   |
+LL | #[doc(alias = "val")]
+   |               +   +
+
+error: expected unsuffixed literal or identifier, found `[`
+  --> $DIR/suggest_quoting_values_only_for_idents.rs:5:15
+   |
+LL | #[doc(alias = ["va", "al"])]
+   |               ^
+
+error: expected unsuffixed literal or identifier, found `&`
+  --> $DIR/suggest_quoting_values_only_for_idents.rs:6:15
+   |
+LL | #[doc(alias = &["va", "al"])]
+   |               ^
+
+error: aborting due to 3 previous errors
+