Skip to content

Add diagnostic item for std::iter::Enumerate #124308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2024
Merged

Add diagnostic item for std::iter::Enumerate #124308

merged 1 commit into from
Apr 24, 2024

Conversation

CBSpeir
Copy link
Contributor

@CBSpeir CBSpeir commented Apr 23, 2024

This adds a diagnostic item for std::iter::Enumerate. The change will be used by the clippy unused_enumerate_index lint to move away from type paths to using diagnostic items.

see: rust-lang/rust-clippy#5393

@rustbot
Copy link
Collaborator

rustbot commented Apr 23, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 23, 2024
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 24, 2024

📌 Commit bcc4469 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2024
fmease added a commit to fmease/rust that referenced this pull request Apr 24, 2024
@fmease
Rollup merge of rust-lang#124308 - CBSpeir:diagnostic-item-enumerate,…
a3e8852 
… r=compiler-errors

Add diagnostic item for `std::iter::Enumerate`

This adds a diagnostic item for `std::iter::Enumerate`.  The change will be used by the clippy `unused_enumerate_index` lint to move away from type paths to using diagnostic items.

see: rust-lang/rust-clippy#5393
@fmease fmease mentioned this pull request Apr 24, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2024
@bors
Auto merge of rust-lang#124316 - fmease:rollup-roq3wei, r=fmease
8e9d22e 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#122500 (delegation: Support renaming, and async, const, extern "ABI" and C-variadic functions)
 - rust-lang#123316 (Test `#[unix_sigpipe = "inherit"]` with both `SIG_DFL` and `SIG_IGN`)
 - rust-lang#124136 (Provide more context and suggestions in borrowck errors involving closures)
 - rust-lang#124280 (Port repr128-dwarf run-make test to rmake)
 - rust-lang#124282 (windows fill_utf16_buf: explain the expected return value)
 - rust-lang#124308 (Add diagnostic item for `std::iter::Enumerate`)

r? `@ghost`
`@rustbot` modify labels: rollup
@fmease fmease mentioned this pull request Apr 24, 2024
Closed
fmease added a commit to fmease/rust that referenced this pull request Apr 24, 2024
@fmease
Rollup merge of rust-lang#124308 - CBSpeir:diagnostic-item-enumerate,…
6671edb 
… r=compiler-errors

Add diagnostic item for `std::iter::Enumerate`

This adds a diagnostic item for `std::iter::Enumerate`.  The change will be used by the clippy `unused_enumerate_index` lint to move away from type paths to using diagnostic items.

see: rust-lang/rust-clippy#5393
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2024
@bors
Auto merge of rust-lang#124329 - fmease:rollup-tzildj5, r=fmease
1f448f7 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#122500 (delegation: Support renaming, and async, const, extern "ABI" and C-variadic functions)
 - rust-lang#123316 (Test `#[unix_sigpipe = "inherit"]` with both `SIG_DFL` and `SIG_IGN`)
 - rust-lang#123794 (More DefineOpaqueTypes::Yes)
 - rust-lang#124282 (windows fill_utf16_buf: explain the expected return value)
 - rust-lang#124308 (Add diagnostic item for `std::iter::Enumerate`)

Failed merges:

 - rust-lang#124136 (Provide more context and suggestions in borrowck errors involving closures)

r? `@ghost`
`@rustbot` modify labels: rollup
@fmease fmease mentioned this pull request Apr 24, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2024
@bors
Auto merge of rust-lang#124330 - fmease:rollup-a98y7jf, r=fmease
f16a83c 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#123316 (Test `#[unix_sigpipe = "inherit"]` with both `SIG_DFL` and `SIG_IGN`)
 - rust-lang#123794 (More DefineOpaqueTypes::Yes)
 - rust-lang#123881 (Bump Fuchsia versions)
 - rust-lang#124281 (fix weak memory bug in TLS on Windows)
 - rust-lang#124282 (windows fill_utf16_buf: explain the expected return value)
 - rust-lang#124308 (Add diagnostic item for `std::iter::Enumerate`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2024
@bors
Auto merge of rust-lang#124330 - fmease:rollup-a98y7jf, r=fmease
ef8b9dc 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#123316 (Test `#[unix_sigpipe = "inherit"]` with both `SIG_DFL` and `SIG_IGN`)
 - rust-lang#123794 (More DefineOpaqueTypes::Yes)
 - rust-lang#123881 (Bump Fuchsia versions)
 - rust-lang#124281 (fix weak memory bug in TLS on Windows)
 - rust-lang#124282 (windows fill_utf16_buf: explain the expected return value)
 - rust-lang#124308 (Add diagnostic item for `std::iter::Enumerate`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit eaeaeb9 into rust-lang:master Apr 24, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2024
@rust-timer
Unrolled build for rust-lang#124308
1e4f7d7 
Rollup merge of rust-lang#124308 - CBSpeir:diagnostic-item-enumerate, r=compiler-errors

Add diagnostic item for `std::iter::Enumerate`

This adds a diagnostic item for `std::iter::Enumerate`.  The change will be used by the clippy `unused_enumerate_index` lint to move away from type paths to using diagnostic items.

see: rust-lang/rust-clippy#5393
@rustbot rustbot added this to the 1.79.0 milestone Apr 24, 2024
@CBSpeir CBSpeir deleted the diagnostic-item-enumerate branch April 24, 2024 21:46
@CBSpeir CBSpeir mentioned this pull request Apr 29, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 1, 2024
@matthiaskrgr
Rollup merge of rust-lang#124542 - CBSpeir:diagnostic-item-enumerate-…
13cd193 
…method, r=scottmcm

Add diagnostic item for `std::iter::Iterator::enumerate`

Adds a diagnostic item for the `std::iter:Iterator::enumerate` trait method. This change, along with PR rust-lang#124308, will be used by the clippy `unused_enumerate_index` lint to move away from paths to using diagnostic items.

see: rust-lang/rust-clippy#5393
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 1, 2024
@matthiaskrgr
Rollup merge of rust-lang#124542 - CBSpeir:diagnostic-item-enumerate-…
38cbad9 
…method, r=scottmcm

Add diagnostic item for `std::iter::Iterator::enumerate`

Adds a diagnostic item for the `std::iter:Iterator::enumerate` trait method. This change, along with PR rust-lang#124308, will be used by the clippy `unused_enumerate_index` lint to move away from paths to using diagnostic items.

see: rust-lang/rust-clippy#5393
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 1, 2024
@rust-timer
Unrolled build for rust-lang#124542
21c0432 
Rollup merge of rust-lang#124542 - CBSpeir:diagnostic-item-enumerate-method, r=scottmcm

Add diagnostic item for `std::iter::Iterator::enumerate`

Adds a diagnostic item for the `std::iter:Iterator::enumerate` trait method. This change, along with PR rust-lang#124308, will be used by the clippy `unused_enumerate_index` lint to move away from paths to using diagnostic items.

see: rust-lang/rust-clippy#5393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
5 participants
@CBSpeir @rustbot @compiler-errors @bors @jieyouxu