rustdoc: check redundant explicit links with correct itemid #123905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Fixes a regression caused by 0a50dba
notriddle
force-pushed
the
notriddle/redundant-explicit-link-hunks
branch
from
af75f29 to
0fea38a
Compare
fmease
added
the
beta-nominated
GuillaumeGomez
approved these changes
Apr 14, 2024
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
|
I'll add |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 14, 2024
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#120900 (std: use `stream_position` where applicable) - rust-lang#123373 (skip Codegen{GCC,Cranelift} when using CI rustc) - rust-lang#123618 (Discard overflow obligations in `impl_may_apply`) - rust-lang#123905 (rustdoc: check redundant explicit links with correct itemid) - rust-lang#123915 (improve documentation slightly regarding some pointer methods) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 14, 2024
Rollup merge of rust-lang#123905 - notriddle:notriddle/redundant-explicit-link-hunks, r=GuillaumeGomez rustdoc: check redundant explicit links with correct itemid Fixes rust-lang#123677 (a regression caused by rust-lang#120702)
GuillaumeGomez
added
the
beta-accepted
Merged
cuviper
removed
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 19, 2024
[beta] backports - Silence `unused_imports` lint for redundant imports rust-lang#123744 - Call the panic hook for non-unwind panics in proc-macros rust-lang#123825 - rustdoc: check redundant explicit links with correct itemid rust-lang#123905 r? cuviper
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 19, 2024
[beta] backports - Silence `unused_imports` lint for redundant imports rust-lang#123744 - Call the panic hook for non-unwind panics in proc-macros rust-lang#123825 - rustdoc: check redundant explicit links with correct itemid rust-lang#123905 - disable two debuginfo tests under gdb 15 rust-lang#123963 r? cuviper
github-merge-queue bot
pushed a commit
to bevyengine/bevy
that referenced
this pull request
Apr 22, 2024
# Objective - rust-lang/rust#123905 has been merged, so the workaround introduced in #12913 is no longer necessary. - Closes #12968 ## Solution - Remove unecessary `allow` attribute - This is currently blocked until Rust beta updates. - Last tested with `rustc 1.78.0-beta.7 (6fd191292 2024-04-12)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123677 (a regression caused by #120702)