Make type_ascribe! not a built-in
#122806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
fmease
approved these changes
Mar 21, 2024
compiler-errors
force-pushed
the
type-ascribe
branch
from
68d2f73 to
a015b90
Compare
|
@bors r=fmease rollup |
bors
added
S-waiting-on-bors
Not worth it imo. Can be done at some other point once ppl using e.g. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 21, 2024
…ease Make `type_ascribe!` not a built-in The only weird thing is the macro expansion note. I wonder if we should suppress these 🤔 r? `@fmease` since you told me about builtin# lol
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Mar 21, 2024
…ease Make `type_ascribe!` not a built-in The only weird thing is the macro expansion note. I wonder if we should suppress these 🤔 r? ``@fmease`` since you told me about builtin# lol
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 21, 2024
…kingjubilee Rollup of 9 pull requests Successful merges: - rust-lang#122222 (deref patterns: bare-bones feature gate and typechecking) - rust-lang#122456 (CFI: Skip non-passed arguments) - rust-lang#122696 (Add bare metal riscv32 target.) - rust-lang#122771 (add some comments to hir::ModuleItems) - rust-lang#122773 (make "expected paren or brace" error translatable) - rust-lang#122795 (Inherit `RUSTC_BOOTSTRAP` when testing wasm) - rust-lang#122799 (Replace closures with `_` when suggesting fully qualified path for method call) - rust-lang#122801 (Fix misc printing issues in emit=stable_mir) - rust-lang#122806 (Make `type_ascribe!` not a built-in) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 21, 2024
…ease Make `type_ascribe!` not a built-in The only weird thing is the macro expansion note. I wonder if we should suppress these 🤔 r? ```@fmease``` since you told me about builtin# lol
This was referenced Mar 21, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 21, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#122222 (deref patterns: bare-bones feature gate and typechecking) - rust-lang#122358 (Don't ICE when encountering bound regions in generator interior type) - rust-lang#122696 (Add bare metal riscv32 target.) - rust-lang#122773 (make "expected paren or brace" error translatable) - rust-lang#122795 (Inherit `RUSTC_BOOTSTRAP` when testing wasm) - rust-lang#122799 (Replace closures with `_` when suggesting fully qualified path for method call) - rust-lang#122801 (Fix misc printing issues in emit=stable_mir) - rust-lang#122806 (Make `type_ascribe!` not a built-in) Failed merges: - rust-lang#122771 (add some comments to hir::ModuleItems) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 21, 2024
Rollup merge of rust-lang#122806 - compiler-errors:type-ascribe, r=fmease Make `type_ascribe!` not a built-in The only weird thing is the macro expansion note. I wonder if we should suppress these 🤔 r? ````@fmease```` since you told me about builtin# lol
This was referenced May 2, 2024
fmease
added a commit
to fmease/rust
that referenced
this pull request
May 3, 2024
…yn, r=compiler-errors AST pretty: Use `builtin_syntax` for type ascription Follow-up to rust-lang#122806. CC #124619.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 3, 2024
…yn, r=compiler-errors AST pretty: Use `builtin_syntax` for type ascription Follow-up to rust-lang#122806. CC #124619.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 3, 2024
Rollup merge of rust-lang#124637 - fmease:ast-pretty-ty-asc-builtin-syn, r=compiler-errors AST pretty: Use `builtin_syntax` for type ascription Follow-up to rust-lang#122806. CC #124619.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only weird thing is the macro expansion note. I wonder if we should suppress these 🤔
r? @fmease since you told me about builtin# lol