Consider middle segments of paths in unused_qualifications
#121528
Merged
+151
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
lcnr
reviewed
Feb 26, 2024
Alexendoo
force-pushed
the
unused_qualifications
branch
from
3d33fea to
172a216
Compare
petrochenkov
reviewed
Mar 1, 2024
petrochenkov
added
S-waiting-on-author
Alexendoo
force-pushed
the
unused_qualifications
branch
from
172a216 to
3246be8
Compare
petrochenkov
reviewed
Mar 2, 2024
|
r=me with #121528 (comment) addressed. |
Alexendoo
force-pushed
the
unused_qualifications
branch
from
3246be8 to
4ea9f72
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 3, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#121248 (Move some tests) - rust-lang#121528 (Consider middle segments of paths in `unused_qualifications`) - rust-lang#121749 (Don't lint on executable crates with `non_snake_case` names) - rust-lang#121935 (library/ptr: mention that ptr::without_provenance is equivalent to deriving from the null ptr) - rust-lang#121945 (Run some ui-fulldeps tests on stage 1 again) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 4, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#121248 (Move some tests) - rust-lang#121528 (Consider middle segments of paths in `unused_qualifications`) - rust-lang#121749 (Don't lint on executable crates with `non_snake_case` names) - rust-lang#121935 (library/ptr: mention that ptr::without_provenance is equivalent to deriving from the null ptr) - rust-lang#121945 (Run some ui-fulldeps tests on stage 1 again) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 4, 2024
Rollup merge of rust-lang#121528 - Alexendoo:unused_qualifications, r=petrochenkov Consider middle segments of paths in `unused_qualifications` Currently `unused_qualifications` looks at the last segment of a path to see if it can be trimmed, this PR extends the check to the middle segments also ```rust // currently linted use std::env::args(); std::env::args(); // Removes `std::env::` ``` ```rust // newly linted use std::env; std::env::args(); // Removes `std::` ``` Paths with generics in them are now linted as long as the part being trimmed is before any generic args, e.g. it will now suggest trimming `std::vec::` from `std::vec::Vec<usize>` Paths with any segments that are from an expansion are no longer linted Fixes rust-lang#100979 Fixes rust-lang#96698
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
unused_qualificationslooks at the last segment of a path to see if it can be trimmed, this PR extends the check to the middle segments alsoPaths with generics in them are now linted as long as the part being trimmed is before any generic args, e.g. it will now suggest trimming
std::vec::fromstd::vec::Vec<usize>Paths with any segments that are from an expansion are no longer linted
Fixes #100979
Fixes #96698