Skip to content

Conversation

@Young-Flash
Copy link
Member

This is my first PR for rustc, which trying to fix #117894, I am not familiar with some internal api so maybe some modification here isn't the way to go, appreciated for any review suggestion.

@rustbot
Copy link
Collaborator

rustbot commented Nov 15, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 15, 2023
@rust-log-analyzer

This comment has been minimized.

Copy link
Member

@fmease fmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks ok. However, I can't approve this PR since I'm only a rustdoc reviewer :')

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2023
@rust-log-analyzer

This comment has been minimized.

@petrochenkov
Copy link
Contributor

r=me after addressing #117934 (comment), #117934 (comment) and squashing commits.

@Young-Flash
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 24, 2023
@petrochenkov
Copy link
Contributor

Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Nov 24, 2023

📌 Commit c710db8 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2023
@bors
Copy link
Collaborator

bors commented Nov 24, 2023

⌛ Testing commit c710db8 with merge 4fd68eb...

@bors
Copy link
Collaborator

bors commented Nov 24, 2023

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 4fd68eb to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 24, 2023
@bors bors merged commit 4fd68eb into rust-lang:master Nov 24, 2023
@rustbot rustbot added this to the 1.76.0 milestone Nov 24, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4fd68eb): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.1% [1.1%, 1.1%] 1
Regressions ❌
(secondary)
1.2% [1.2%, 1.2%] 1
Improvements ✅
(primary)
-3.2% [-3.7%, -2.7%] 2
Improvements ✅
(secondary)
-3.4% [-6.9%, -1.1%] 3
All ❌✅ (primary) -1.8% [-3.7%, 1.1%] 3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.644s -> 677.24s (0.38%)
Artifact size: 313.53 MiB -> 313.50 MiB (-0.01%)

@Young-Flash
Copy link
Member Author

Great,thanks @petrochenkov and @fmease for patient review 😁

@Young-Flash Young-Flash deleted the dev branch December 12, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

For a typo let_some_variable =, suggest let some_variable = instead of let let_some_variable =

7 participants