Skip to content

Conversation

matthiaskrgr
Copy link
Member

we will always return once we step inside the while-loop thus if is sufficient here

we will always return once we step inside the while-loop thus `if` is sufficient here
@rustbot
Copy link
Collaborator

rustbot commented Sep 27, 2023

r? @GuillaumeGomez

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 27, 2023
@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 27, 2023

📌 Commit 809ab64 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2023
@bors
Copy link
Collaborator

bors commented Sep 28, 2023

⌛ Testing commit 809ab64 with merge 2ba4eb2...

@bors
Copy link
Collaborator

bors commented Sep 28, 2023

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 2ba4eb2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 28, 2023
@bors bors merged commit 2ba4eb2 into rust-lang:master Sep 28, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 28, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2ba4eb2): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.265s -> 631.789s (0.08%)
Artifact size: 317.27 MiB -> 317.34 MiB (0.02%)

@matthiaskrgr matthiaskrgr deleted the the_loop_that_wasnt branch January 25, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants