Dont suggest use between use and cfg attr
#115630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
rust-cloud-vms
bot
force-pushed
the
dont-suggest-use-btw-use-and-attr
branch
from
db876d1 to
84e8b3f
Compare
rust-cloud-vms
bot
force-pushed
the
dont-suggest-use-btw-use-and-attr
branch
from
84e8b3f to
03bee1f
Compare
wesleywiser
approved these changes
Sep 8, 2023
|
Thanks @compiler-errors! 🎉 @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 8, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#113807 (Tests crash from inappropriate use of common linkage) - rust-lang#115358 (debuginfo: add compiler option to allow compressed debuginfo sections) - rust-lang#115630 (Dont suggest use between `use` and cfg attr) - rust-lang#115662 (Improve "associated type not found" diagnostics) - rust-lang#115673 (Fix sanitize/cfg.rs test) r? `@ghost` `@rustbot` modify labels: rollup
cjgillot
reviewed
Sep 8, 2023
Comment on lines
-2756
to
+2762
| return Some(item.span.shrink_to_lo()); | ||
| let mut lo = item.span.lo(); | ||
| for attr in &item.attrs { | ||
| if attr.span.eq_ctxt(item.span) { | ||
| lo = std::cmp::min(lo, attr.span.lo()); | ||
| } | ||
| } | ||
| return Some(Span::new(lo, lo, item.span.ctxt(), item.span.parent())); |
There was a problem hiding this comment.
Should this use item.span_with_attributes().lo()?
There was a problem hiding this comment.
Didn't know we even had that.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 9, 2023
Rollup merge of rust-lang#115630 - compiler-errors:dont-suggest-use-btw-use-and-attr, r=wesleywiser Dont suggest use between `use` and cfg attr Fixes rust-lang#115618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115618