Skip to content

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Aug 29, 2023

We can just use resolve_bound_vars to compute these indices faithfully.

This also makes the code easier to support where clauses on non_lifetime_binders (like where for<T: Debug> ..., etc, which I've got a WIP implementation of).

r? @cjgillot

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 29, 2023
@cjgillot
Copy link
Contributor

cjgillot commented Sep 3, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 3, 2023

📌 Commit c5d0f6c has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2023
@bors
Copy link
Collaborator

bors commented Sep 3, 2023

⌛ Testing commit c5d0f6c with merge 53a0397...

@bors
Copy link
Collaborator

bors commented Sep 3, 2023

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 53a0397 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 3, 2023
@bors bors merged commit 53a0397 into rust-lang:master Sep 3, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 3, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (53a0397): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.3% [-0.5%, -0.2%] 5
Improvements ✅
(secondary)
-0.5% [-0.6%, -0.4%] 2
All ❌✅ (primary) -0.3% [-0.5%, -0.2%] 5

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.0% [-2.7%, -1.2%] 2
Improvements ✅
(secondary)
-1.4% [-1.4%, -1.4%] 1
All ❌✅ (primary) -2.0% [-2.7%, -1.2%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 630.051s -> 628.237s (-0.29%)
Artifact size: 316.64 MiB -> 316.75 MiB (0.04%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants