Fix size_hint for EncodeUtf16 #113898
Merged
Fix size_hint for EncodeUtf16 #113898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cuviper (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
cuviper
reviewed
Jul 21, 2023
library/core/src/str/iter.rs
Outdated
| // long as the underlying iterator. | ||
| (low, high.and_then(|n| n.checked_mul(2))) | ||
| let len = self.chars.iter.len(); | ||
| // The highest bytes:code units ratio occurs for 3-byte sequences, so |
There was a problem hiding this comment.
I think this could explicitly mention surrogates, something like "because a 4-byte sequence will map to 2 code units as a surrogate pair," so we're covering the prior misconception about the output being twice as long.
Everything else looks good to me!
There was a problem hiding this comment.
Added some extra details.
|
Thanks! @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 22, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#112490 (Remove `#[cfg(all())]` workarounds from `c_char`) - rust-lang#113252 (Update the tracking issue for `const_cstr_from_ptr`) - rust-lang#113442 (Allow limited access to `OsString` bytes) - rust-lang#113876 (fix docs & example for `std::os::unix::prelude::FileExt::write_at`) - rust-lang#113898 (Fix size_hint for EncodeUtf16) - rust-lang#113934 (Multibyte character removal in String::pop and String::remove doctests) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More realistic upper and lower bounds, and handle the case where the iterator is located within a surrogate pair.
Resolves #113897