Directly link more target docs #113743
Merged
Directly link more target docs #113743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
For examples of targets that I noticed did have platform support docs that might be relevant, but weren't directly linked:
RV64GC isn't supported by the Fuchsia SDK, as I understand it, so that's why it isn't documented clearly. And they're both tier 3 anyways so currently my feeling is "whatever". This was spurred by #113739 |
Some platforms were not linked from platform-support.md This fixes that, but errs towards extremely conservative, only directly linking platform docs if the docs actively mention the target, as otherwise I do not necessarily know if there was a reason for the omission.
workingjubilee
force-pushed
the
link-more-platform-support-docs
branch
from
244d0b0 to
467cb52
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 1, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#111081 (impl SliceIndex<str> for (Bound<usize>, Bound<usize>)) - rust-lang#113394 (style-guide: Document style editions, start 2024 style edition) - rust-lang#113588 (bootstrap: use git merge-base for LLVM CI download logic) - rust-lang#113743 (Directly link more target docs) - rust-lang#114262 (Improve the rust style guide doc) - rust-lang#114309 (Update books) - rust-lang#114313 ([rustc_data_structures] Simplify SortedMap::insert.) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some platforms were not linked from platform-support.md
This fixes that, but errs towards extremely conservative, only directly linking platform docs if the docs actively mention the target, as otherwise I do not necessarily know if there was a reason for the omission.