Skip to content

Conversation

psumbera
Copy link
Contributor

@psumbera psumbera commented Jun 26, 2023

This fixes build regression after e7e584b.

Resolves #113085

@rustbot
Copy link
Collaborator

rustbot commented Jun 26, 2023

r? @ozkanonur

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 26, 2023
Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR :)

I haven't tested this. I will try to test it during this week. Adding a reference to the problem/error that this PR fix would be great.

@onur-ozkan
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2023
@psumbera psumbera force-pushed the solaris-bootstrap-cfgs branch from 1587afa to 38b60a1 Compare June 27, 2023 08:27
@rust-log-analyzer

This comment has been minimized.

@psumbera psumbera force-pushed the solaris-bootstrap-cfgs branch from 38b60a1 to e7ba37d Compare June 27, 2023 08:35
@psumbera psumbera force-pushed the solaris-bootstrap-cfgs branch from e7ba37d to 35cfac1 Compare June 27, 2023 12:29
@psumbera psumbera requested a review from onur-ozkan June 27, 2023 12:31
@onur-ozkan
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 28, 2023

📌 Commit 35cfac1 has been approved by ozkanonur

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 28, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 29, 2023
Rollup of 5 pull requests

Successful merges:

 - rust-lang#112946 (Improve cgu naming and ordering)
 - rust-lang#113048 (Fix build on Solaris where fd-lock cannot be used.)
 - rust-lang#113100 (Fix display of long items in search results)
 - rust-lang#113107 (add check for ConstKind::Value(_) to in_operand())
 - rust-lang#113119 (rustdoc: Reduce internal function visibility.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 376c944 into rust-lang:master Jun 29, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: unused import - when building Rust on Solaris where isn't fd-lock available
5 participants