Skip to content

resolve: Minor cleanup to fn resolve_path_with_ribs #112892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2023
Merged

resolve: Minor cleanup to fn resolve_path_with_ribs #112892

merged 1 commit into from
Jun 21, 2023
+38 −51

Conversation

petrochenkov
Copy link
Contributor

A single-use closure is inlined and one unnecessary enum is removed.

Noticed when reviewing #112686.

@petrochenkov
resolve: Minor cleanup to fn resolve_path_with_ribs
c007293 
A single-use closure is inlined and one unnecessary enum is removed.
@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2023

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 21, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Jun 21, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 21, 2023

📌 Commit c007293 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 21, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 21, 2023
@bors
Auto merge of rust-lang#112900 - GuillaumeGomez:rollup-1blf4io, r=Gui…
065a1f5 
…llaumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#112538 (Removed unnecessary &String -> &str, now that &String implements StableOrd as well)
 - rust-lang#112868 (Liberate bound vars properly when suggesting missing async-fn-in-trait)
 - rust-lang#112892 (resolve: Minor cleanup to `fn resolve_path_with_ribs`)
 - rust-lang#112894 (Fix union fields display)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d938be1 into rust-lang:master Jun 21, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 21, 2023
@estebank estebank mentioned this pull request Jun 22, 2023
Merged
@petrochenkov petrochenkov deleted the cleanres branch February 22, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
4 participants
@petrochenkov @rustbot @oli-obk @bors