Rewrite various resolve/diagnostics errors as translatable diagnostics #112768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d_macro_suggestions
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
WaffleLapkin
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
A few nits, but overall looks good.
For trivial strings is it ever accepted to use
fluent_generated::fooin alabelfor example? Or is an emptystruct Diagnosticpreferred?
I think, an empty struct is preferred, but I'd suggest you ask in the i18n or t-compiler/wg-diagnostics zulip streams.
WaffleLapkin
added
S-waiting-on-author
|
@rustbot review |
rustbot
added
S-waiting-on-review
WaffleLapkin
approved these changes
Jun 19, 2023
|
@bors r+ |
bors
added
S-waiting-on-bors
|
@bors rollup |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 19, 2023
…ve1, r=WaffleLapkin Rewrite various resolve/diagnostics errors as translatable diagnostics additional question: For trivial strings is it ever accepted to use `fluent_generated::foo` in a `label` for example? Or is an empty struct `Diagnostic` preferred?
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 19, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#109970 ([doc] `poll_fn`: explain how to `pin` captured state safely) - rust-lang#112705 (Simplify `Span::source_callee` impl) - rust-lang#112757 (Use BorrowFlag instead of explicit isize) - rust-lang#112768 (Rewrite various resolve/diagnostics errors as translatable diagnostics) - rust-lang#112777 (Continue folding in query normalizer on weak aliases) - rust-lang#112780 (Treat TAIT equation as always ambiguous in coherence) - rust-lang#112783 (Don't ICE on bound var in `reject_fn_ptr_impls`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additional question:
For trivial strings is it ever accepted to use
fluent_generated::fooin alabelfor example? Or is an empty structDiagnosticpreferred?