Make simd_shuffle_indices use valtrees #112718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
RalfJung
reviewed
Jun 17, 2023
cjgillot
reviewed
Jun 24, 2023
| let val = cx.tcx.destructure_mir_constant(cx.param_env, val); | ||
| val.fields.iter().any(|field| inner(cx, *field)) | ||
| ty::Array(ty, _) => { | ||
| val.unwrap_branch().iter().any(|field| inner(cx, *field, ty)) |
There was a problem hiding this comment.
I don't know enough of valtrees. Is there code which emits an error if this is not a branch?
There was a problem hiding this comment.
The compiler created a bad valtree if a valtree of array type is not a branch. So we don't report an error, but we never get a Some from eval_const_to_valtree
| .destructure_mir_constant(ty::ParamEnv::reveal_all(), c) | ||
| .fields | ||
| let values: Vec<_> = val | ||
| .unwrap_branch() |
There was a problem hiding this comment.
Which code emits an error if this is not a branch?
cjgillot
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #113022) made this pull request unmergeable. Please resolve the merge conflicts. |
oli-obk
force-pushed
the
SIMD-destructure_mir_const
branch
from
8ad9571 to
1c992c0
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 30, 2023
…, r=cjgillot Make simd_shuffle_indices use valtrees This removes the second-to-last user of the `destructure_mir_constant` query. So in a follow-up we can remove the query and just move the query provider function directly into pretty printing (which is the last user). cc `@rust-lang/clippy` there's a small functional change, but I think it is correct?
TaKO8Ki
added a commit
to TaKO8Ki/rust
that referenced
this pull request
Jul 1, 2023
…, r=cjgillot Make simd_shuffle_indices use valtrees This removes the second-to-last user of the `destructure_mir_constant` query. So in a follow-up we can remove the query and just move the query provider function directly into pretty printing (which is the last user). cc ``@rust-lang/clippy`` there's a small functional change, but I think it is correct?
|
⌛ Testing commit 1c992c0 with merge 642527ae563c8e8a5b38ee984d1b8b24dde92faa... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 1c992c0 with merge bfb2944298bd7549a8d905036a59c09dc69525f7... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (72b2101): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 662.143s -> 662.283s (0.02%) |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 14, 2023
…r=cjgillot Make simd_shuffle_indices use valtrees This removes the second-to-last user of the `destructure_mir_constant` query. So in a follow-up we can remove the query and just move the query provider function directly into pretty printing (which is the last user). cc `@rust-lang/clippy` there's a small functional change, but I think it is correct?
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jun 27, 2025
… r=BoxyUwU Move an ACE test out of the GCI directory In rust-lang#122988, a test pertaining to `associated_const_equality` was placed into the directory meant for `generic_const_items`. Let's move it where it belongs. While at it, I took the time to further minimize the test and to add a description. You can use 1.67.1 (as reported in rust-lang#108220) to verify that I didn't butcher it. For additional context, the issue was likely fixed in rust-lang#112718 (but I'm also cc'ing rust-lang#140467 which further fixed things up and has more context). I only performed quick and dirty git/GitHub archeology, so I don't have the full picture here. For one, I'm not even sure if this regression test is worth it. Anyway, I just want it gone from the GCI dir :)
rust-timer
added a commit
that referenced
this pull request
Jun 27, 2025
Rollup merge of #143056 - fmease:mv-ace-test-out-of-gci-dir, r=BoxyUwU Move an ACE test out of the GCI directory In #122988, a test pertaining to `associated_const_equality` was placed into the directory meant for `generic_const_items`. Let's move it where it belongs. While at it, I took the time to further minimize the test and to add a description. You can use 1.67.1 (as reported in #108220) to verify that I didn't butcher it. For additional context, the issue was likely fixed in #112718 (but I'm also cc'ing #140467 which further fixed things up and has more context). I only performed quick and dirty git/GitHub archeology, so I don't have the full picture here. For one, I'm not even sure if this regression test is worth it. Anyway, I just want it gone from the GCI dir :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the second-to-last user of the
destructure_mir_constantquery. So in a follow-up we can remove the query and just move the query provider function directly into pretty printing (which is the last user).cc @rust-lang/clippy there's a small functional change, but I think it is correct?